Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Norsk Bokmål translations #1877

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Added Norsk Bokmål translations #1877

merged 1 commit into from
Oct 5, 2021

Conversation

Exouxas
Copy link
Contributor

@Exouxas Exouxas commented Oct 4, 2021

What does this PR do?

Added translations for Norsk Bokmål

Test Plan

I've run the code on Docker and used Postman to test the translations.

Related PRs and Issues

Issue #1755

Have you read the Contributing Guidelines on issues?

I have read the guidelines.

@christyjacob4 christyjacob4 merged commit 7c4c47b into appwrite:locale Oct 5, 2021
@christyjacob4
Copy link
Member

Please use the master branch and create a new PR

@Exouxas
Copy link
Contributor Author

Exouxas commented Oct 5, 2021

@christyjacob4 Apologies for putting it in the wrong branch, I believe I misinterpreted the guide document. Just to make sure I understand it: Do you want me to make a branch out of locale named feat-1755-norwegian-bokmaal-translation, and then make a pull request from that branch to master?

@christyjacob4
Copy link
Member

@Exouxas , you can checkout from master, make the same changes that you made here and raise another PR to master

@christyjacob4 christyjacob4 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 6, 2021
@Exouxas
Copy link
Contributor Author

Exouxas commented Oct 15, 2021

Just wanted to mention that this PR is replaced by #2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants