Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Event Modal #218

Merged
merged 19 commits into from
Feb 8, 2023
Merged

Refactor Event Modal #218

merged 19 commits into from
Feb 8, 2023

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Dec 15, 2022

What does this PR do?

  • Refactors/organizes event modal code
  • Fixes bugs in the event modal selection
  • Adds helper strings on event modal custom input
  • Allows editing of previously created events
  • Fixes attribute naming conventions

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the enhancement New feature or request label Dec 15, 2022
@TGlide TGlide self-assigned this Dec 15, 2022
@vercel
Copy link

vercel bot commented Dec 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
console ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 10:13AM (UTC)

TorstenDittmann
TorstenDittmann reviewed Jan 10, 2023
View reviewed changes
src/lib/components/copy.svelte Outdated Show resolved Hide resolved
src/lib/components/eventModal.svelte Outdated Show resolved Hide resolved
src/lib/components/eventModal.svelte Outdated Show resolved Hide resolved
@TorstenDittmann
Copy link
Contributor

Bildschirm­foto 2023-01-27 um 13 30 39

Code wise looks good! But there is a small issue with the event text input 👀

@TGlide
Copy link
Contributor Author

TGlide commented Jan 30, 2023

Bildschirm­foto 2023-01-27 um 13 30 39

Code wise looks good! But there is a small issue with the event text input eyes

Fixed!

@TGlide TGlide mentioned this pull request Jan 31, 2023
Closed
@TorstenDittmann TorstenDittmann merged commit cbe9055 into main Feb 8, 2023
@TorstenDittmann TorstenDittmann deleted the refactor-event-modal branch February 8, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@ArmanNik ArmanNik Awaiting requested review from ArmanNik

Assignees

@TGlide TGlide

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TGlide @TorstenDittmann