Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary __call__ functions for clarity #115

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

afaulconbridge
Copy link
Contributor

@afaulconbridge afaulconbridge commented Nov 26, 2020

The Reader and Writer classes currently uses the python special __call__ method names so instances can be executed as functions. However, these are only called as functions internally from class methods, and therefore the same functionality can be done by a more straightforward public method. This makes it easier to understand the code and maintain.

@apriha apriha merged commit 3da0fce into apriha:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants