governance proposals for concurrent fa balance #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AIP: AIP-70
Release: supported by v1.14
Security Consideration
Main capability powering this feature is AggregatorsV2. They have been extensively tested (including replay is the same when they are using simple sequential fallback), and audited by OtterSec, and have been in production for months.
Code for concurrent FA balance itself is short, and has been audited by Aptos Labs. For the past 3 weeks, we have run devnet with defaulting all new accounts to concurrent FA balance.
Test Result
state-sync via execution mode on devnet, with aggregators disabled, succeeds.
This feature has been enabled in devnet and testnet since end of June.
for aggregators themselves, passing replay-verify of mainnet and testnet, with simple sequential fallback.
Ecosystem Impact
In v1.14, we have the callout:
Breaking Changes
FungibleStore.balance
+ConcurrentFungibleBalance.balance
. If using indexer, this change will make it transparently handled by provided processors.fungible_asset::balance
view function will continue providing correct balance.CONCURRENT_FUNGIBLE_BALANCE