Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance proposals for concurrent fa balance #89

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

igor-aptos
Copy link
Contributor

@igor-aptos igor-aptos commented Aug 30, 2024

Description

AIP: AIP-70
Release: supported by v1.14

Security Consideration

Main capability powering this feature is AggregatorsV2. They have been extensively tested (including replay is the same when they are using simple sequential fallback), and audited by OtterSec, and have been in production for months.

Code for concurrent FA balance itself is short, and has been audited by Aptos Labs. For the past 3 weeks, we have run devnet with defaulting all new accounts to concurrent FA balance.

Test Result

state-sync via execution mode on devnet, with aggregators disabled, succeeds.
This feature has been enabled in devnet and testnet since end of June.

for aggregators themselves, passing replay-verify of mainnet and testnet, with simple sequential fallback.

Ecosystem Impact

In v1.14, we have the callout:

Breaking Changes

  • [AIP-70] Parallelize Fungible Assets - opt-in parallel fungible balance
    • Ecosystem Impact: In order to track fungible asset balances correctly (for the accounts that opt-in to the new feature), now both old and new field needs to be summed up: FungibleStore.balance + ConcurrentFungibleBalance.balance. If using indexer, this change will make it transparently handled by provided processors. fungible_asset::balance view function will continue providing correct balance.
    • Dependencies: None
    • Feature Flag: CONCURRENT_FUNGIBLE_BALANCE

@igor-aptos igor-aptos marked this pull request as draft September 4, 2024 19:59
@igor-aptos igor-aptos force-pushed the igor/release_concurrent_balance branch from a79ab7b to 7af2aa4 Compare September 23, 2024 21:56
@igor-aptos igor-aptos changed the title governance proposals for concurrent fa balance and efficient object derived address governance proposals for concurrent fa balance Sep 25, 2024
@igor-aptos igor-aptos marked this pull request as ready for review September 25, 2024 17:47
@sherry-x sherry-x merged commit 536f687 into main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants