display all aptogotchi holders to demonstrate indexer usage #26
Conversation
0xaptosj
commented
Oct 19, 2023
•
0xaptosj
commented
- setup ci to test move code
- add publish script
- displaying all aptogotchi holders to demonstrate indexer usage (probably need to update the ui to make it more friendly)
- make get aptogotchi address a view function so we can call it to get token data then collection data.
0xaptosj
requested review from
angieyth,
darren-wangg,
blakezimmerman and
0xZihan
and removed request for
angieyth and
darren-wangg
0xaptosj
changed the title
| } | ||
| `, | ||
| variables: { | ||
| collection_id: collectionResponse.collection_id, |
There was a problem hiding this comment.
can collection_id be queried from a view function in the contract? it's never gonna change so doesn't seem clean to query it every time with the token address.
| console.log(JSON.stringify(tokenDataResponse, null, 2)); | ||
| console.log( | ||
| JSON.stringify( | ||
| // @ts-ignore |
There was a problem hiding this comment.
Is it possible to handle this properly?
0xaptosj
force-pushed
the
j/showcase-indexer-usage
branch
from
0aa8380
to
3bc2e80
Compare
frontend/src/app/home/Connected.tsx
Outdated
| const { account, network } = useWallet(); | ||
|
|
||
| const fetchPet = useCallback(async () => { | ||
| if (!account?.address) return; | ||
|
|
||
| const payload = { | ||
| const getAptogotchiPayload = { |
There was a problem hiding this comment.
nit: inline to L25 if this variable isn't being used anywhere else
There was a problem hiding this comment.
I feel it's kinda nice to give a name to it to improve readability. But maybe I missed some benefit of making it inline.
frontend/src/app/home/Connected.tsx
Outdated
| const noPet = ["", "0", "0", "0x"]; | ||
|
|
||
| if (JSON.stringify(response) !== JSON.stringify(noPet)) { | ||
| if (JSON.stringify(aptogotchiResponse) !== JSON.stringify(noPet)) { |
There was a problem hiding this comment.
We shouldn't stringify just to do a comparison. We should compare named values so that it's more readable.
For example:
const [name, birthday, energyPoints, parts) = await provider.view(getAptogotchiPayload);
const noPet = {name: "", birthday: 0, energyPoints: 0, parts: 0x};
if (birthday !== noPet.birthday) {
...
}
if (aptogotchiResponse
frontend/src/app/home/Connected.tsx
Outdated
| .split("0") | ||
| .slice(2) | ||
| .map(Number), | ||
| }); | ||
| } | ||
| }, [account?.address]); | ||
|
|
||
| const fetchCollectionID = useCallback(async () => { |
There was a problem hiding this comment.
nit: I would inline this function into L66 if it's the only place used.
frontend/src/app/home/Connected.tsx
Outdated
|
|
||
| const aptogotchiCollectionIDResponse = (await provider.view( | ||
| getAptogotchiCollectionIDPayload | ||
| )) as string[]; |
There was a problem hiding this comment.
more tight typing if it as [string] or [0x${string}]
| const [collectionHolders, setCollectionHolders] = | ||
| useState<CollectionHolder[]>(); | ||
|
|
||
| const fetchCollection = useCallback(async () => { |
frontend/src/app/home/Connected.tsx
Outdated
| const { account, network } = useWallet(); | ||
|
|
||
| const fetchPet = useCallback(async () => { | ||
| if (!account?.address) return; | ||
|
|
||
| const payload = { | ||
| const getAptogotchiPayload = { |
There was a problem hiding this comment.
I feel it's kinda nice to give a name to it to improve readability. But maybe I missed some benefit of making it inline.
