Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptogotchi] support aip-62 in wallet adapter #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

angieyth
Copy link
Collaborator

change to new wallet adapter implementation after AIP-62

@angieyth angieyth requested a review from 0xaptosj May 30, 2024 21:51
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptogotchi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:14pm

"@emotion/react": "^11.11.1",
"@emotion/styled": "^11.11.0",
"@radix-ui/react-dialog": "^1.0.5",
"@wallet-standard/core": "^1.0.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont think you need it

"@emotion/react": "^11.11.1",
"@emotion/styled": "^11.11.0",
"@radix-ui/react-dialog": "^1.0.5",
"@wallet-standard/core": "^1.0.3",
"aptos": ">=1.21.0 <2.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you still using old sdk?

package.json Outdated
@@ -0,0 +1,5 @@
{
"dependencies": {
"@aptos-labs/wallet-adapter-react": "^2.3.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably use 3.0.2

@@ -11,16 +11,18 @@
"gen-abi": "./gen_abi.sh"
},
"dependencies": {
"@aptos-labs/ts-sdk": "^1.5.1",
"@aptos-labs/wallet-adapter-react": "^2.1.7",
"@aptos-labs/ts-sdk": "^1.13.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use latest? 1.17.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants