Omit warning only for first parameter named self, to scope impact

aptos-labs · Aug 21, 2024 · 63fbb86 · 63fbb86
1 parent dedd6f2
commit 63fbb86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/third_party/move/move-compiler/src/hlir/ast.rs b/third_party/move/move-compiler/src/hlir/ast.rs
@@ -371,6 +371,13 @@ impl FunctionSignature {
             .iter()
             .any(|(parameter_name, _)| parameter_name == v)
     }
+
+    pub fn is_first_parameter(&self, v: &Var) -> bool {
+        self.parameters
+            .first()
+            .map(|(parameter_name, _)| parameter_name == v)
+            .unwrap_or(false)
+    }
 }
 
 impl Command_ {

diff --git a/third_party/move/move-compiler/src/hlir/translate.rs b/third_party/move/move-compiler/src/hlir/translate.rs
@@ -1972,7 +1972,7 @@ fn check_unused_locals(
             DisplayVar::Tmp => panic!("ICE unused tmp"),
             DisplayVar::Orig(vstr) => vstr,
         };
-        if signature.is_parameter(&v) && vstr == "self" {
+        if signature.is_first_parameter(&v) && vstr == "self" {
             // Special treatment for `self` Move 2 parameter: do not warn if unused
             // for the case v1 compiles v2 code
             continue;