Skip to content

Commit

Permalink
remove dry_run env flag (#14992)
Browse files Browse the repository at this point in the history
(cherry picked from commit 46364e9)
  • Loading branch information
aluon authored and sherry-x committed Oct 28, 2024
1 parent 9a44d73 commit 9c922eb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/copy-images-to-dockerhub.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,4 @@ jobs:
AWS_ACCOUNT_ID: ${{ secrets.AWS_ECR_ACCOUNT_NUM }}
GCP_DOCKER_ARTIFACT_REPO: ${{ vars.GCP_DOCKER_ARTIFACT_REPO }}
IMAGE_TAG_PREFIX: ${{ inputs.image_tag_prefix }}
DRY_RUN: ${{ inputs.dry_run }}
run: ./docker/release-images.mjs --wait-for-image-seconds=3600 ${{ inputs.dry_run && '--dry-run' || '' }}
1 change: 1 addition & 0 deletions docker/release-images.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ async function main() {
const imageTarget = `${targetRegistry}/${image}:${joinTagSegments(parsedArgs.IMAGE_TAG_PREFIX, profilePrefix, featureSuffix)}`;
console.info(chalk.green(`INFO: copying ${imageSource} to ${imageTarget}`));
if (parsedArgs.DRY_RUN) {
console.info(chalk.yellow(`INFO: skipping copy of ${imageSource} to ${imageTarget} due to dry run`));
continue;
}
await waitForImageToBecomeAvailable(imageSource, parsedArgs.WAIT_FOR_IMAGE_SECONDS);
Expand Down

0 comments on commit 9c922eb

Please sign in to comment.