jwk #2: ensure jwk txns are expected in consensus #11855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjma
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11855 +/- ##
===========================================
- Coverage 71.2% 69.9% -1.3%
===========================================
Files 795 2181 +1386
Lines 182968 413637 +230669
===========================================
+ Hits 130275 289389 +159114
- Misses 52693 124248 +71555 ☔ View full report in Codecov by Sentry. |
grao1991
approved these changes
Feb 2, 2024
zekun000
reviewed
Feb 2, 2024
| @@ -73,6 +76,17 @@ pub fn storage(config: &SafetyRulesConfig) -> PersistentSafetyStorage { | |||
| } | |||
| } | |||
|
|
|||
| pub fn load_consensus_key_from_secure_storage( | |||
There was a problem hiding this comment.
we already have something for DKG?
consensus/src/util/mod.rs
Outdated
|
|
||
| pub fn is_vtxn_expected(features: &Features, vtxn: &ValidatorTransaction) -> bool { | ||
| match vtxn { | ||
| ValidatorTransaction::DummyTopic1(_) | ValidatorTransaction::DummyTopic2(_) => true, |
There was a problem hiding this comment.
this shouldn't be true, it opens ddos attacks by validators? honestly I don't think it should even exist on non-testing path
There was a problem hiding this comment.
once the corresponding feature is enabled, DKG/JWK txn are similar?
There was a problem hiding this comment.
DKG/JWK has verification logic that only valid ones can go through? the dummy txn execution just succeeds?
fixed |
danielxiangzl
approved these changes
Feb 3, 2024
…_jwk_txn_expected
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan