Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwk #3: jwk consensus deps, network, and type defs #11856

Merged
merged 14 commits into from
Feb 5, 2024
Merged

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 1, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 1, 2024

⏱️ 45h 48m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 24h 🟥🟥
rust-unit-tests 7h 21m 🟥🟥🟩 (+5 more)
rust-smoke-coverage 6h 7m 🟩🟩
windows-build 3h 53m 🟩🟩🟩🟩🟩 (+5 more)
run-tests-main-branch 42m 🟩🟩🟩🟩 (+5 more)
rust-lints 42m 🟩🟩🟩 (+5 more)
check 33m 🟩🟩🟩 (+5 more)
rust-smoke-tests 29m 🟩
general-lints 23m 🟩🟩🟩 (+5 more)
execution-performance / single-node-performance 19m 🟩
check-dynamic-deps 19m 🟩🟩🟩🟩🟩 (+5 more)
rust-images / rust-all 16m 🟩
forge-e2e-test / forge 14m 🟩
forge-compat-test / forge 12m 🟩
cli-e2e-tests / run-cli-tests 7m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
permission-check 34s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 31s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 29s 🟩🟩🟩🟩🟩 (+5 more)
permission-check 25s 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 12s 🟩
execution-performance / file_change_determinator 9s 🟩
permission-check 7s 🟩
determine-docker-build-metadata 4s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma changed the title jwk consensus network type defs jwk #3: jwk consensus deps, network, and type defs Feb 1, 2024
@zjma zjma added the JWK label Feb 1, 2024
}

#[derive(Clone, Debug, Deserialize, Serialize, PartialEq)]
pub struct ObservedUpdateRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No version number attached?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, right now if received peer observation has a different version, we reject.

Base automatically changed from zjma/consensus_ensure_jwk_txn_expected to main February 5, 2024 02:34
@zjma zjma marked this pull request as ready for review February 5, 2024 03:21
@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 5, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 4dec5084d281bfead46a54219c57a36b6a94181c

Compatibility test results for aptos-node-v1.8.3 ==> 4dec5084d281bfead46a54219c57a36b6a94181c (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4725 txn/s, latency: 6755 ms, (p50: 5700 ms, p90: 10000 ms, p99: 19000 ms), latency samples: 184300
2. Upgrading first Validator to new version: 4dec5084d281bfead46a54219c57a36b6a94181c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1771 txn/s, latency: 15726 ms, (p50: 19200 ms, p90: 22100 ms, p99: 22600 ms), latency samples: 92140
3. Upgrading rest of first batch to new version: 4dec5084d281bfead46a54219c57a36b6a94181c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1163 txn/s, latency: 24610 ms, (p50: 28300 ms, p90: 34100 ms, p99: 35000 ms), latency samples: 60520
4. upgrading second batch to new version: 4dec5084d281bfead46a54219c57a36b6a94181c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2707 txn/s, latency: 11759 ms, (p50: 10200 ms, p90: 22100 ms, p99: 26100 ms), latency samples: 116420
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 4dec5084d281bfead46a54219c57a36b6a94181c passed
Test Ok

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ Forge suite realistic_env_max_load success on 4dec5084d281bfead46a54219c57a36b6a94181c

two traffics test: inner traffic : committed: 7250 txn/s, latency: 5287 ms, (p50: 4800 ms, p90: 6800 ms, p99: 11400 ms), latency samples: 3139420
two traffics test : committed: 100 txn/s, latency: 2120 ms, (p50: 2100 ms, p90: 2500 ms, p99: 2800 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.268, avg: 0.202", "QsPosToProposal: max: 0.144, avg: 0.136", "ConsensusProposalToOrdered: max: 0.573, avg: 0.533", "ConsensusOrderedToCommit: max: 0.482, avg: 0.456", "ConsensusProposalToCommit: max: 1.020, avg: 0.989"]
Max round gap was 1 [limit 4] at version 1360491. Max no progress secs was 5.190539 [limit 15] at version 1360491.
Test Ok

@zjma zjma merged commit dae6f11 into main Feb 5, 2024
79 of 84 checks passed
@zjma zjma deleted the zjma/jwk_network_msg_defs branch February 5, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR JWK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants