[Aptos VM] Reduce some unnecessary transaction metadata instantiation

[junkil-park]

Description

Reduce the unnecessary transaction metadata instantiation

This PR resolves #12546

[trunk-io]

⏱️ 4h 57m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-unit-tests	1h 16m	🟩 🟩 🟩
windows-build	53m	🟩 🟩 🟩
rust-smoke-tests	37m	🟩
rust-lints	22m	🟥 🟩 🟩
execution-performance / single-node-performance	21m	🟩
rust-images / rust-all	14m	🟩
forge-e2e-test / forge	14m	🟩
forge-compat-test / forge	13m	🟩
check	12m	🟩 🟩 🟩
run-tests-main-branch	12m	🟥 🟥 🟥
check-dynamic-deps	6m	🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	6m	🟩
general-lints	6m	🟩 🟩 🟩
semgrep/ci	1m	🟩 🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	54s	🟩
file_change_determinator	30s	🟩 🟩 🟩
file_change_determinator	28s	🟩 🟩 🟩
permission-check	15s	🟩 🟩 🟩
permission-check	13s	🟩 🟩 🟩
file_change_determinator	10s	🟩
permission-check	9s	🟩 🟩 🟩
execution-performance / file_change_determinator	9s	🟩
permission-check	9s	🟩 🟩 🟩
permission-check	4s	🟩
determine-docker-build-metadata	2s	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 2168c8927e52a88fa0800218c8da1007d1792bc4

Compatibility test results for aptos-node-v1.9.5 ==> 2168c8927e52a88fa0800218c8da1007d1792bc4 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6903 txn/s, latency: 4798 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 241620
2. Upgrading first Validator to new version: 2168c8927e52a88fa0800218c8da1007d1792bc4
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 675 txn/s, latency: 34894 ms, (p50: 36600 ms, p90: 55100 ms, p99: 57800 ms), latency samples: 56040
3. Upgrading rest of first batch to new version: 2168c8927e52a88fa0800218c8da1007d1792bc4
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 364 txn/s, submitted: 517 txn/s, expired: 153 txn/s, latency: 42202 ms, (p50: 41700 ms, p90: 57300 ms, p99: 58400 ms), latency samples: 31709
4. upgrading second batch to new version: 2168c8927e52a88fa0800218c8da1007d1792bc4
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3093 txn/s, latency: 9788 ms, (p50: 9700 ms, p90: 14700 ms, p99: 16000 ms), latency samples: 136100
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 2168c8927e52a88fa0800218c8da1007d1792bc4 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 2168c8927e52a88fa0800218c8da1007d1792bc4

two traffics test: inner traffic : committed: 7233 txn/s, latency: 5418 ms, (p50: 5100 ms, p90: 6900 ms, p99: 10500 ms), latency samples: 3124980
two traffics test : committed: 100 txn/s, latency: 2032 ms, (p50: 1900 ms, p90: 2200 ms, p99: 6100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.227, avg: 0.204", "QsPosToProposal: max: 0.343, avg: 0.306", "ConsensusProposalToOrdered: max: 0.485, avg: 0.463", "ConsensusOrderedToCommit: max: 0.327, avg: 0.308", "ConsensusProposalToCommit: max: 0.787, avg: 0.771"]
Max round gap was 1 [limit 4] at version 1500724. Max no progress secs was 4.404866 [limit 15] at version 1500724.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking