Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] move flag to local config #12556

Merged
merged 1 commit into from
Mar 16, 2024
Merged

[consensus] move flag to local config #12556

merged 1 commit into from
Mar 16, 2024

Conversation

danielxiangzl
Copy link
Contributor

Description

Move the broadcast vote flag to consensus local config.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 16, 2024

@danielxiangzl danielxiangzl enabled auto-merge (squash) March 16, 2024 17:46

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 6cc101a1b0211a718f7192d5da51cb74ed3f8975

Compatibility test results for aptos-node-v1.9.5 ==> 6cc101a1b0211a718f7192d5da51cb74ed3f8975 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6757 txn/s, latency: 4947 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9600 ms), latency samples: 236500
2. Upgrading first Validator to new version: 6cc101a1b0211a718f7192d5da51cb74ed3f8975
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1460 txn/s, latency: 18830 ms, (p50: 19000 ms, p90: 24900 ms, p99: 25900 ms), latency samples: 73040
3. Upgrading rest of first batch to new version: 6cc101a1b0211a718f7192d5da51cb74ed3f8975
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 138 txn/s, submitted: 526 txn/s, expired: 387 txn/s, latency: 40026 ms, (p50: 38500 ms, p90: 57200 ms, p99: 57300 ms), latency samples: 10562
4. upgrading second batch to new version: 6cc101a1b0211a718f7192d5da51cb74ed3f8975
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2165 txn/s, latency: 13726 ms, (p50: 15100 ms, p90: 16300 ms, p99: 17500 ms), latency samples: 97460
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 6cc101a1b0211a718f7192d5da51cb74ed3f8975 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 6cc101a1b0211a718f7192d5da51cb74ed3f8975

two traffics test: inner traffic : committed: 7660 txn/s, latency: 5116 ms, (p50: 4800 ms, p90: 6000 ms, p99: 13200 ms), latency samples: 3309520
two traffics test : committed: 100 txn/s, latency: 1887 ms, (p50: 1800 ms, p90: 2100 ms, p99: 6100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.220, avg: 0.204", "QsPosToProposal: max: 0.340, avg: 0.269", "ConsensusProposalToOrdered: max: 0.471, avg: 0.427", "ConsensusOrderedToCommit: max: 0.330, avg: 0.310", "ConsensusProposalToCommit: max: 0.777, avg: 0.736"]
Max round gap was 1 [limit 4] at version 1522305. Max no progress secs was 6.110302 [limit 15] at version 1522305.
Test Ok

@danielxiangzl danielxiangzl merged commit 36cd163 into main Mar 16, 2024
82 checks passed
@danielxiangzl danielxiangzl deleted the daniel-config branch March 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants