Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: less vector allocation #13271

Closed
wants to merge 1 commit into from
Closed

trivial: less vector allocation #13271

wants to merge 1 commit into from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented May 13, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 13, 2024

⏱️ 3h 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
single-node-performance 1h 55m 🟥🟥🟥
rust-targeted-unit-tests 31m 🟩🟩
rust-lints 20m 🟩🟩
rust-move-tests 13m 🟩🟩🟩
run-tests-main-branch 12m 🟩🟩🟩
test-target-determinator 8m 🟩🟩
general-lints 5m 🟩🟩🟩
check-dynamic-deps 3m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
file_change_determinator 29s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 10m 7m +48%
rust-move-tests 7m 12m -44%

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant