Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt #2: switch high-perf-docker to runs-on.com runners #13851

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

geekflyer
Copy link
Contributor

@geekflyer geekflyer commented Jun 28, 2024

Reintroducing runs-on runners as high-perf-docker replacement again. This is after flakyness issues that were observed last time have been resolved.
This time using AWS custom AMI build by @ibalajiarun .

@geekflyer geekflyer requested a review from a team as a code owner June 28, 2024 00:10
Copy link

trunk-io bot commented Jun 28, 2024

@geekflyer geekflyer requested a review from ibalajiarun June 28, 2024 00:10
@geekflyer geekflyer enabled auto-merge (squash) June 28, 2024 00:13
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.0%. Comparing base (1c2ee70) to head (aa4edbe).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #13851     +/-   ##
=========================================
- Coverage    59.0%    59.0%   -0.1%     
=========================================
  Files         819      819             
  Lines      197276   197313     +37     
=========================================
  Hits       116485   116485             
- Misses      80791    80828     +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> aa4edbe8647f57da8538d678f27982bdf6aa6a8c

Compatibility test results for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> aa4edbe8647f57da8538d678f27982bdf6aa6a8c (PR)
1. Check liveness of validators at old version: f648076a280621dbfd4e73b1ca83e3a3f52878ed
compatibility::simple-validator-upgrade::liveness-check : committed: 8042.769833675988 txn/s, latency: 3558.8081046105694 ms, (p50: 2700 ms, p90: 3600 ms, p99: 29200 ms), latency samples: 332280
2. Upgrading first Validator to new version: aa4edbe8647f57da8538d678f27982bdf6aa6a8c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3137.4197357483126 txn/s, latency: 8384.38803131991 ms, (p50: 9000 ms, p90: 10700 ms, p99: 11600 ms), latency samples: 71520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3138.7406057473745 txn/s, latency: 9856.048864437862 ms, (p50: 9800 ms, p90: 14600 ms, p99: 15100 ms), latency samples: 141780
3. Upgrading rest of first batch to new version: aa4edbe8647f57da8538d678f27982bdf6aa6a8c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3478.959254934774 txn/s, latency: 7435.6969941520465 ms, (p50: 9000 ms, p90: 9700 ms, p99: 10200 ms), latency samples: 85500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3210.1804625811674 txn/s, latency: 9650.030051057622 ms, (p50: 9600 ms, p90: 14700 ms, p99: 15100 ms), latency samples: 137100
4. upgrading second batch to new version: aa4edbe8647f57da8538d678f27982bdf6aa6a8c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 623.5089400752504 txn/s, submitted: 864.4337989304272 txn/s, expired: 240.92485885517686 txn/s, latency: 24421.015466346773 ms, (p50: 3600 ms, p90: 56400 ms, p99: 57100 ms), latency samples: 46682
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6632.153428392815 txn/s, latency: 5005.217097862767 ms, (p50: 5100 ms, p90: 7500 ms, p99: 8400 ms), latency samples: 231140
5. check swarm health
Compatibility test for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> aa4edbe8647f57da8538d678f27982bdf6aa6a8c passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on aa4edbe8647f57da8538d678f27982bdf6aa6a8c

two traffics test: inner traffic : committed: 8464.866407673398 txn/s, latency: 4629.959369032703 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3655340
two traffics test : committed: 99.93242685523276 txn/s, latency: 2013.0916666666667 ms, (p50: 2000 ms, p90: 2200 ms, p99: 3300 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.222, avg: 0.216", "QsPosToProposal: max: 0.258, avg: 0.233", "ConsensusProposalToOrdered: max: 0.324, avg: 0.290", "ConsensusOrderedToCommit: max: 0.379, avg: 0.359", "ConsensusProposalToCommit: max: 0.667, avg: 0.649"]
Max round gap was 1 [limit 4] at version 301306. Max no progress secs was 4.953653 [limit 15] at version 2914423.
Test Ok

@geekflyer geekflyer disabled auto-merge June 28, 2024 00:44
@geekflyer geekflyer merged commit ad42e03 into main Jun 28, 2024
88 of 94 checks passed
@geekflyer geekflyer deleted the runs-on-again branch June 28, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants