Improve QS backpressure counter

[igor-aptos]

Description

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 2h 18m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
test-fuzzers	43m	🟩 🟥
forge-framework-upgrade-test / forge	17m	🟩
forge-compat-test / forge	16m	🟩
forge-e2e-test / forge	15m	🟩
execution-performance / test-target-determinator	9m	🟩
test-target-determinator	8m	🟩
rust-move-tests	6m	🟩
rust-move-tests	6m	🟩
general-lints	4m	🟩 🟩
check	4m	🟩
rust-cargo-deny	3m	🟩 🟩
check-dynamic-deps	2m	🟩 🟩
semgrep/ci	52s	🟩 🟩
file_change_determinator	26s	🟩 🟩
file_change_determinator	26s	🟩 🟩
file_change_determinator	25s	🟩
permission-check	11s	🟩 🟩
Backport PR	10s	🟥
execution-performance / single-node-performance	10s	🟩
permission-check	8s	🟩 🟩
permission-check	7s	🟩
permission-check	5s	🟩 🟩
permission-check	4s	🟩 🟩
permission-check	2s	🟩
determine-docker-build-metadata	2s	🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / test-target-determinator	9m	5m
forge-framework-upgrade-test / forge	17m	10m
test-target-determinator	8m	5m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[bchocho]

LG. I wonder if we want an indicator of how much stricter, but this binary counter seems in line with the consensus backpressure.

[github-actions]

✅ Forge suite realistic_env_max_load success on 309e5c2973091261933c347dd6e23c4df1cf494c

two traffics test: inner traffic : committed: 9157.9880747208 txn/s, latency: 4348.767169802652 ms, (p50: 4200 ms, p90: 4800 ms, p99: 11100 ms), latency samples: 3482160
two traffics test : committed: 100.04974430279334 txn/s, latency: 2310.780588235294 ms, (p50: 2100 ms, p90: 2500 ms, p99: 7700 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.253, avg: 0.225", "QsPosToProposal: max: 1.916, avg: 1.838", "ConsensusProposalToOrdered: max: 0.321, avg: 0.297", "ConsensusOrderedToCommit: max: 0.424, avg: 0.411", "ConsensusProposalToCommit: max: 0.719, avg: 0.707"]
Max round gap was 1 [limit 4] at version 1908029. Max no progress secs was 5.710875 [limit 15] at version 1908029.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 7751.756543050354 txn/s, latency: 4083.343423359086 ms, (p50: 3000 ms, p90: 5000 ms, p99: 29200 ms), latency samples: 308060
2. Upgrading first Validator to new version: 309e5c2973091261933c347dd6e23c4df1cf494c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4779.6866773336005 txn/s, latency: 6116.526835911964 ms, (p50: 4900 ms, p90: 7700 ms, p99: 10300 ms), latency samples: 91780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6458.068918045263 txn/s, latency: 4646.422731364046 ms, (p50: 4700 ms, p90: 5300 ms, p99: 6300 ms), latency samples: 244420
3. Upgrading rest of first batch to new version: 309e5c2973091261933c347dd6e23c4df1cf494c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5508.7651829634515 txn/s, latency: 5020.200369754113 ms, (p50: 5600 ms, p90: 6300 ms, p99: 6400 ms), latency samples: 108180
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5052.999575013328 txn/s, latency: 5504.802815 ms, (p50: 5600 ms, p90: 6200 ms, p99: 7100 ms), latency samples: 200000
4. upgrading second batch to new version: 309e5c2973091261933c347dd6e23c4df1cf494c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8335.769912742007 txn/s, latency: 3270.1488381001022 ms, (p50: 3300 ms, p90: 4800 ms, p99: 7800 ms), latency samples: 156640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7227.662859980051 txn/s, latency: 4477.260623674495 ms, (p50: 3600 ms, p90: 7600 ms, p99: 9700 ms), latency samples: 254620
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c (PR)
Upgrade the nodes to version: 309e5c2973091261933c347dd6e23c4df1cf494c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1111.2008097770884 txn/s, submitted: 1113.1383874750431 txn/s, failed submission: 1.9375776979548185 txn/s, expired: 1.9375776979548185 txn/s, latency: 3152.1560047951175 ms, (p50: 2200 ms, p90: 5400 ms, p99: 11700 ms), latency samples: 91760
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1163.0886094256223 txn/s, submitted: 1165.3181722551922 txn/s, failed submission: 2.229562829569883 txn/s, expired: 2.229562829569883 txn/s, latency: 2958.45066027689 ms, (p50: 2100 ms, p90: 5700 ms, p99: 13300 ms), latency samples: 93900
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 309e5c2973091261933c347dd6e23c4df1cf494c passed
Upgrade the remaining nodes to version: 309e5c2973091261933c347dd6e23c4df1cf494c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1099.4674833358345 txn/s, submitted: 1103.0227540984401 txn/s, failed submission: 3.5552707626057702 txn/s, expired: 3.5552707626057702 txn/s, latency: 2952.9636418755053 ms, (p50: 2100 ms, p90: 5700 ms, p99: 11700 ms), latency samples: 98960
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking