Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce frequency of calls to calculate remaining txns in proof queue #14533

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

vusirikala
Copy link
Contributor

Description

Reduce frequency of calls to calculate remaining txns in proof queue.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 5, 2024

⏱️ 2h 32m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-framework-upgrade-test / forge 37m 🟥🟥🟩
forge-compat-test / forge 35m 🟩🟩
forge-e2e-test / forge 27m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 8m 🟩🟩
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 4m 🟩🟩🟩
general-lints 4m 🟩🟩
rust-cargo-deny 4m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 35s 🟩🟩🟩
file_change_determinator 34s 🟩🟩🟩
execution-performance / single-node-performance 22s 🟩🟩
file_change_determinator 21s 🟩🟩
permission-check 18s 🟩🟩🟩
permission-check 11s 🟩🟩
rust-move-tests 11s
determine-docker-build-metadata 10s 🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
Backport PR 6s 🟥
permission-check 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
forge-compat-test / forge 13m 17m -25%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vusirikala vusirikala requested review from sitalkedia and igor-aptos and removed request for sasha8 and gelash September 5, 2024 00:07
@vusirikala vusirikala enabled auto-merge (squash) September 5, 2024 00:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 11890.28 txn/s, latency: 2856.13 ms, (p50: 2200 ms, p70: 2400, p90: 6800 ms, p99: 13600 ms), latency samples: 418520
2. Upgrading first Validator to new version: 61046272b1c53605afe5fc8f666ed8bac2200eca
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7238.31 txn/s, latency: 3770.72 ms, (p50: 4200 ms, p70: 4700, p90: 5000 ms, p99: 5200 ms), latency samples: 128260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6795.01 txn/s, latency: 4426.32 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 6000 ms), latency samples: 256320
3. Upgrading rest of first batch to new version: 61046272b1c53605afe5fc8f666ed8bac2200eca
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5594.84 txn/s, latency: 5121.79 ms, (p50: 5900 ms, p70: 6200, p90: 6300 ms, p99: 6500 ms), latency samples: 109560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5224.69 txn/s, latency: 6235.90 ms, (p50: 6700 ms, p70: 7200, p90: 8300 ms, p99: 8500 ms), latency samples: 193000
4. upgrading second batch to new version: 61046272b1c53605afe5fc8f666ed8bac2200eca
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11150.89 txn/s, latency: 2432.39 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3100 ms), latency samples: 197000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11444.30 txn/s, latency: 2728.45 ms, (p50: 2600 ms, p70: 2800, p90: 3600 ms, p99: 5200 ms), latency samples: 368020
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca passed
Test Ok

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Forge suite realistic_env_max_load success on 61046272b1c53605afe5fc8f666ed8bac2200eca

two traffics test: inner traffic : committed: 12008.33 txn/s, latency: 3296.33 ms, (p50: 2900 ms, p70: 3000, p90: 4200 ms, p99: 10600 ms), latency samples: 4565920
two traffics test : committed: 100.09 txn/s, latency: 3006.93 ms, (p50: 2500 ms, p70: 2600, p90: 4500 ms, p99: 9700 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.239, avg: 0.225", "QsPosToProposal: max: 0.492, avg: 0.292", "ConsensusProposalToOrdered: max: 0.326, avg: 0.310", "ConsensusOrderedToCommit: max: 0.534, avg: 0.489", "ConsensusProposalToCommit: max: 0.859, avg: 0.799"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.90s no progress at version 2555489 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.55s no progress at version 2555487 (avg 7.55s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Forge suite framework_upgrade success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca (PR)
Upgrade the nodes to version: 61046272b1c53605afe5fc8f666ed8bac2200eca
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1221.91 txn/s, submitted: 1224.83 txn/s, failed submission: 2.92 txn/s, expired: 2.92 txn/s, latency: 2529.26 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5100 ms), latency samples: 108820
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1096.15 txn/s, submitted: 1098.24 txn/s, failed submission: 2.09 txn/s, expired: 2.09 txn/s, latency: 2990.08 ms, (p50: 2700 ms, p70: 3000, p90: 5200 ms, p99: 7200 ms), latency samples: 94380
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 61046272b1c53605afe5fc8f666ed8bac2200eca passed
Upgrade the remaining nodes to version: 61046272b1c53605afe5fc8f666ed8bac2200eca
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1118.74 txn/s, submitted: 1120.56 txn/s, failed submission: 1.83 txn/s, expired: 1.83 txn/s, latency: 2808.13 ms, (p50: 2400 ms, p70: 2900, p90: 4500 ms, p99: 6800 ms), latency samples: 97880
Test Ok

@vusirikala vusirikala merged commit 862cc33 into main Sep 9, 2024
48 checks passed
@vusirikala vusirikala deleted the satya/reduce_remaining_txns branch September 9, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants