Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] canary forge indexer #14577

Closed
wants to merge 13 commits into from

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Sep 10, 2024

Description

Canary for #14547

Specify FORGE_ENABLE_INDEXER=true in the env file

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

This is the test for #14547

Key Areas to Review

#14547 does not implement SuccessCriteria based on the indexer yet. We will check via the dashboards/logs if the indexer is live and running as intended.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 10, 2024

⏱️ 1h 34m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
adhoc-forge-test / forge 30m 🟥🟩🟩
check-dynamic-deps 14m 🟩🟩🟩🟩🟩 (+6 more)
rust-cargo-deny 11m 🟩🟩🟩🟩 (+4 more)
general-lints 10m 🟩🟩🟩🟥 (+5 more)
rust-move-tests 10m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
file_change_determinator 2m 🟩🟩🟩🟩 (+5 more)
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 1m 🟩
rust-move-tests 57s
rust-move-tests 48s
permission-check 34s 🟩🟩🟩🟩🟩 (+6 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@rustielin rustielin force-pushed the rustielin/forge-indexer-canary branch 9 times, most recently from f0c97ff to 6e11ea5 Compare September 11, 2024 22:11
@rustielin rustielin force-pushed the rustielin/forge-indexer-canary branch 4 times, most recently from cc56b69 to 987f77a Compare September 26, 2024 17:36
@rustielin rustielin added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 26, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@rustielin rustielin force-pushed the rustielin/forge-indexer-canary branch 2 times, most recently from 10f9a31 to 515772e Compare September 27, 2024 01:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2608219bf4a910fce57a1ee3908c088d0947f62e

two traffics test: inner traffic : committed: 13292.08 txn/s, latency: 3077.80 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 13600 ms), latency samples: 5053940
two traffics test : committed: 99.89 txn/s, latency: 5261.15 ms, (p50: 1600 ms, p70: 2600, p90: 10700 ms, p99: 46200 ms), latency samples: 1960
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.243, avg: 0.225", "QsPosToProposal: max: 0.955, avg: 0.672", "ConsensusProposalToOrdered: max: 0.320, avg: 0.306", "ConsensusOrderedToCommit: max: 0.504, avg: 0.479", "ConsensusProposalToCommit: max: 0.809, avg: 0.785"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.24s no progress at version 1429889 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.23s no progress at version 5477617 (avg 8.16s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b6187e1794550f4a6b25cab0e5d40188574241da ==> 2608219bf4a910fce57a1ee3908c088d0947f62e

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> 2608219bf4a910fce57a1ee3908c088d0947f62e (PR)
1. Check liveness of validators at old version: b6187e1794550f4a6b25cab0e5d40188574241da
compatibility::simple-validator-upgrade::liveness-check : committed: 11872.19 txn/s, latency: 2733.66 ms, (p50: 2100 ms, p70: 2600, p90: 5200 ms, p99: 7600 ms), latency samples: 410180
2. Upgrading first Validator to new version: 2608219bf4a910fce57a1ee3908c088d0947f62e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7672.87 txn/s, latency: 3653.53 ms, (p50: 4000 ms, p70: 4300, p90: 4400 ms, p99: 4600 ms), latency samples: 142560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7143.09 txn/s, latency: 4241.05 ms, (p50: 4100 ms, p70: 4300, p90: 4500 ms, p99: 7500 ms), latency samples: 274560
3. Upgrading rest of first batch to new version: 2608219bf4a910fce57a1ee3908c088d0947f62e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7273.56 txn/s, latency: 3899.56 ms, (p50: 4300 ms, p70: 4600, p90: 4800 ms, p99: 4800 ms), latency samples: 139100
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6884.06 txn/s, latency: 4681.18 ms, (p50: 4600 ms, p70: 4800, p90: 7100 ms, p99: 7300 ms), latency samples: 233580
4. upgrading second batch to new version: 2608219bf4a910fce57a1ee3908c088d0947f62e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10134.94 txn/s, latency: 2631.93 ms, (p50: 2800 ms, p70: 3000, p90: 3300 ms, p99: 3400 ms), latency samples: 183200
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9627.69 txn/s, latency: 3240.98 ms, (p50: 3100 ms, p70: 3600, p90: 4600 ms, p99: 5900 ms), latency samples: 331180
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> 2608219bf4a910fce57a1ee3908c088d0947f62e passed
Test Ok

@rustielin rustielin closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant