-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event V2 Translation #14615
Open
junkil-park
wants to merge
1
commit into
main
Choose a base branch
from
jpark/event-v2-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Event V2 Translation #14615
+1,870
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 42m total CI duration on this PR
|
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
9 times, most recently
from
September 16, 2024 16:22
50b9c0f
to
832b754
Compare
grao1991
previously requested changes
Sep 16, 2024
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
4 times, most recently
from
September 24, 2024 03:46
80c5021
to
bfbe123
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
10 times, most recently
from
October 3, 2024 16:15
123fbfe
to
27650b3
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
from
October 4, 2024 16:52
27650b3
to
c202506
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
2 times, most recently
from
October 16, 2024 11:27
ccd6843
to
c38fc96
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
2 times, most recently
from
October 23, 2024 07:11
32088d7
to
523e22f
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
2 times, most recently
from
October 28, 2024 17:57
66904c8
to
8bd7449
Compare
junkil-park
requested review from
msmouse,
lightmark,
gregnazario,
JoshLind,
alinush,
davidiw,
movekevin,
wrwg,
banool and
0xmaayan
as code owners
October 28, 2024 17:58
junkil-park
requested review from
areshand,
bowenyang007,
igor-aptos,
larry-aptos and
grao1991
October 28, 2024 17:58
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
from
October 28, 2024 17:58
8bd7449
to
26f2530
Compare
junkil-park
force-pushed
the
jpark/event-v2-translation
branch
from
November 4, 2024 19:17
26f2530
to
de5e74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Event V2 Translation Engine, a framework for translating well-known V2 events into V1 format. So, the Node APIs can output those events in the V1 format.
Added the new flag
enable_event_v2_translation
to the node config for feature-gating.Added the event translators in the account and coin modules, translating:
Added a new feature flag
ACCOUNT_AND_COIN_MODULE_EVENT_MIGRATION
, and used it to guard the event migration for the account and coin modules. So, we can ship this first.Implemented the e2e API test environment where we can simulate and test the module event migration. And, added the e2e tests for the event transaction for the account and coin modules.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Tested on the localnet.
Added various e2e API tests.
Key Areas to Review
Checklist