-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move maybe_evict_cache() off default rayon pool #15068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 31m total CI duration on this PR
|
grao1991
approved these changes
Oct 23, 2024
msmouse
added
the
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
label
Oct 23, 2024
zekun000
approved these changes
Oct 23, 2024
This can potentially block the pre_commit_ledger thread while it's holding the buffered_state lock. Before we reduce the scope of that lock, I'm moving this part off the defualt pool so that even if the default pool gets busy (or worse, there are tasks on the threads of the pool trying to lock the buffered_state) this part doesn't get affected.
msmouse
force-pushed
the
1023-alden-evict-cache-off-default-pool
branch
from
October 23, 2024 23:36
3b5cd91
to
a29d236
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can potentially block the pre_commit_ledger thread while it's holding the buffered_state lock. Before we reduce the scope of that lock, I'm moving this part off the defualt pool so that even if the default pool gets busy (or worse, there are tasks on the threads of the pool trying to lock the buffered_state) this part doesn't get affected.
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?