select jwk in move #15107
Draft
select jwk in move #15107
+208
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 42m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
zjma
commented
Oct 29, 2024
| pk.inner_keyless_pk().iss_val.as_bytes().to_vec().as_move_value(), | ||
| sig.parse_jwt_header().unwrap().kid.as_bytes().to_vec().as_move_value(), | ||
| ]; | ||
| let move_ret_val = session.execute_function_bypass_visibility( |
alinush
reviewed
Oct 29, 2024
| let federated_jwks = get_federated_jwks_onchain(resolver, &fed_pk.jwk_addr) | ||
| .map_err(|_| { | ||
| invalid_signature!(format!( | ||
| let jwk = if std::env::var("FIND_JWK_IN_MOVE").unwrap_or_default().as_str() == "1" { //TODO: gated by a flag instead |
alinush
reviewed
Oct 29, 2024
| } | ||
|
|
||
| all_times.sort(); | ||
| println!("P50={:?}", all_times[50]); |
There was a problem hiding this comment.
Are you running this with cargo test --release I hope? :)
zjma
force-pushed
the
zjma/debug1026
branch
3 times, most recently
from
38bfcb7
to
21d1b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When validating a keyless txn, we find a JWK by iss.
This
find_jwk_by_issprocess is currently in VM, and we are moving it to the framework for better upgradability.Potential dependency: #15139
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist