-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable optqs #15158
Draft
ibalajiarun
wants to merge
4
commits into
balaji/optqs-co
Choose a base branch
from
balaji/optqs-eval2
base: balaji/optqs-co
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
enable optqs #15158
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 3h 24m total CI duration on this PR
|
ibalajiarun
added
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:run-forge-e2e-perf
Run the e2e perf forge only
labels
Nov 1, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
testsuite/forge-cli/src/main.rs
Outdated
Comment on lines
240
to
241
// let suite_name: &str = args.suite.as_ref(); | ||
let suite_name = "realistic_env_load_sweep"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change hardcodes suite_name = "realistic_env_load_sweep"
, bypassing the command line argument parsing. This makes the CLI's -s/--suite
flag non-functional. Please restore the original line:
let suite_name: &str = args.suite.as_ref();
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ibalajiarun
force-pushed
the
balaji/optqs-eval2
branch
from
November 5, 2024 03:36
4fce7b1
to
f372523
Compare
ibalajiarun
force-pushed
the
balaji/optqs-eval2
branch
from
November 5, 2024 03:36
f372523
to
bed452e
Compare
ibalajiarun
added
CICD:run-forge-e2e-perf
Run the e2e perf forge only
and removed
CICD:run-forge-e2e-perf
Run the e2e perf forge only
labels
Nov 5, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ibalajiarun
force-pushed
the
balaji/optqs-co
branch
from
November 5, 2024 04:57
459bb53
to
012832f
Compare
ibalajiarun
force-pushed
the
balaji/optqs-eval2
branch
from
November 5, 2024 04:57
1836955
to
b42898c
Compare
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:run-forge-e2e-perf
Run the e2e perf forge only
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist