Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable optqs #15158

Draft
wants to merge 4 commits into
base: balaji/optqs-co
Choose a base branch
from
Draft

enable optqs #15158

wants to merge 4 commits into from

Conversation

ibalajiarun
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 1, 2024

⏱️ 3h 24m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 1h 4m 🟥🟥
test-target-determinator 36m 🟩🟩🟩🟩 (+4 more)
rust-cargo-deny 15m 🟩🟩🟩🟩 (+4 more)
check-dynamic-deps 11m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 7m
general-lints 5m 🟩🟩🟩🟩 (+4 more)
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 2m 🟩
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+4 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun added CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-forge-e2e-perf Run the e2e perf forge only labels Nov 1, 2024

This comment has been minimized.

This comment has been minimized.

Base automatically changed from balaji/timeout-author to main November 1, 2024 23:51
Comment on lines 240 to 241
// let suite_name: &str = args.suite.as_ref();
let suite_name = "realistic_env_load_sweep";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change hardcodes suite_name = "realistic_env_load_sweep", bypassing the command line argument parsing. This makes the CLI's -s/--suite flag non-functional. Please restore the original line:

let suite_name: &str = args.suite.as_ref();

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun changed the base branch from main to balaji/optqs-co November 5, 2024 03:36
@ibalajiarun ibalajiarun added CICD:run-forge-e2e-perf Run the e2e perf forge only and removed CICD:run-forge-e2e-perf Run the e2e perf forge only labels Nov 5, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Forge suite realistic_env_max_load success on b42898c146a2ab927be5e227189699b91307dfb8

two traffics test: inner traffic : committed: 10776.29 txn/s, latency: 3636.85 ms, (p50: 3300 ms, p70: 4100, p90: 5400 ms, p99: 8700 ms), latency samples: 4097400
two traffics test : committed: 99.91 txn/s, latency: 3021.57 ms, (p50: 2400 ms, p70: 3200, p90: 5200 ms, p99: 8600 ms), latency samples: 1880
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.867, avg: 0.499", "ConsensusProposalToOrdered: max: 0.337, avg: 0.292", "ConsensusOrderedToCommit: max: 0.323, avg: 0.306", "ConsensusProposalToCommit: max: 0.613, avg: 0.598"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 18165 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 6.25s no progress at version 1449478 (avg 5.68s) [limit 15].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant