Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyless circuit #15181

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Remove keyless circuit #15181

merged 3 commits into from
Nov 4, 2024

Conversation

mstraka100
Copy link
Contributor

Description

Removes the keyless circuit from the repo. Specifically deletes keyless/circuit and keyless/common, both of which have been moved to https://github.com/aptos-labs/keyless-zk-proofs

How Has This Been Tested?

Made sure all crates in keyless/pepper still compiled including tests.

Key Areas to Review

Make sure there are no crates depending on either keyless/circuit or keyless/common in the repo that were missed.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (keyless circuit)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 4, 2024

⏱️ 1h 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-cargo-deny 7m 🟩🟩🟩
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
check-dynamic-deps 4m 🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
run-all-circuit-tests 2m 🟥
rust-move-tests 2m
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 17m +48%

settingsfeedbackdocs ⋅ learn more about trunk.io

@mstraka100 mstraka100 self-assigned this Nov 4, 2024
Copy link
Contributor

@zjma zjma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: also remove the CI "run-all-circuit-tests"

@mstraka100 mstraka100 requested a review from a team as a code owner November 4, 2024 22:10
@mstraka100 mstraka100 enabled auto-merge (squash) November 4, 2024 22:23

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Forge suite realistic_env_max_load success on a83f7fcff71ea6ef9e21ca1a1e11833547a8e300

two traffics test: inner traffic : committed: 14265.41 txn/s, latency: 2784.38 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5424020
two traffics test : committed: 99.99 txn/s, latency: 1583.65 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 11200 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.061, avg: 1.569", "ConsensusProposalToOrdered: max: 0.338, avg: 0.297", "ConsensusOrderedToCommit: max: 0.372, avg: 0.358", "ConsensusProposalToCommit: max: 0.666, avg: 0.655"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.97s no progress at version 2563280 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.37s no progress at version 2563278 (avg 8.37s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300 (PR)
Upgrade the nodes to version: a83f7fcff71ea6ef9e21ca1a1e11833547a8e300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1309.36 txn/s, submitted: 1311.85 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2366.86 ms, (p50: 2400 ms, p70: 2400, p90: 3100 ms, p99: 5400 ms), latency samples: 115620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1246.53 txn/s, submitted: 1250.38 txn/s, failed submission: 3.84 txn/s, expired: 3.84 txn/s, latency: 2427.89 ms, (p50: 2300 ms, p70: 2600, p90: 4100 ms, p99: 5400 ms), latency samples: 110260
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300 passed
Upgrade the remaining nodes to version: a83f7fcff71ea6ef9e21ca1a1e11833547a8e300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1207.26 txn/s, submitted: 1210.10 txn/s, failed submission: 2.84 txn/s, expired: 2.84 txn/s, latency: 2414.89 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5300 ms), latency samples: 110440
Test Ok

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300 (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 14219.83 txn/s, latency: 2366.74 ms, (p50: 1800 ms, p70: 1900, p90: 3600 ms, p99: 11200 ms), latency samples: 543660
2. Upgrading first Validator to new version: a83f7fcff71ea6ef9e21ca1a1e11833547a8e300
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4224.77 txn/s, latency: 6902.09 ms, (p50: 7400 ms, p70: 8000, p90: 8300 ms, p99: 8600 ms), latency samples: 88180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4625.85 txn/s, latency: 7051.77 ms, (p50: 7300 ms, p70: 7900, p90: 8200 ms, p99: 8400 ms), latency samples: 162720
3. Upgrading rest of first batch to new version: a83f7fcff71ea6ef9e21ca1a1e11833547a8e300
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7006.91 txn/s, latency: 3967.72 ms, (p50: 4000 ms, p70: 4600, p90: 5400 ms, p99: 5800 ms), latency samples: 133440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6954.26 txn/s, latency: 4643.00 ms, (p50: 4900 ms, p70: 5200, p90: 5800 ms, p99: 6500 ms), latency samples: 237820
4. upgrading second batch to new version: a83f7fcff71ea6ef9e21ca1a1e11833547a8e300
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8610.29 txn/s, latency: 3324.58 ms, (p50: 3500 ms, p70: 3800, p90: 4300 ms, p99: 4600 ms), latency samples: 158980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7608.10 txn/s, latency: 4225.22 ms, (p50: 3700 ms, p70: 4900, p90: 6300 ms, p99: 7300 ms), latency samples: 253840
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> a83f7fcff71ea6ef9e21ca1a1e11833547a8e300 passed
Test Ok

@mstraka100 mstraka100 merged commit 2d95075 into main Nov 4, 2024
91 of 92 checks passed
@mstraka100 mstraka100 deleted the michael/remove_keyless_circuit branch November 4, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants