Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decompiler] Downgrade to bytecode v6 for Revela #15597

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[decompiler] Downgrade to bytecode v6 for Revela #15597

merged 1 commit into from
Dec 13, 2024
+57 −2

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Dec 13, 2024

Description

Since the bytecode version default is v7, Revela cannot be used at all anymore. This PR attempts to downgrade to v6 before calling Revela, if possible. This allows to continue to work with Revela until the new decompiler is available.

How Has This Been Tested?

Manually

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

@wrwg
[decompiler] Downgrade to bytecode v6 for Revela
c449e70 
Since the bytecode version default is v7, Revela cannot be used at all anymore. This PR attempts to downgrade to v6 before calling Revela, if possible. This allows to continue to work with Revela until the new decompiler is available.
@trunk-io Trunk.io
Copy link

trunk-io bot commented Dec 13, 2024 •
edited
Loading

⏱️ 53m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩 
rust-move-tests 13m 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 4m 🟩 
execution-performance / test-target-determinator 4m 🟩 
check 4m 🟩 
rust-cargo-deny 4m 🟩 🟩 
check-dynamic-deps 2m 🟩 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
general-lints 56s 🟩 🟩 
semgrep/ci 47s 🟩 🟩 
file_change_determinator 22s 🟩 🟩 
file_change_determinator 12s 🟩 
permission-check 11s 🟩 🟩 
execution-performance / single-node-performance 10s 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@wrwg Graphite App
Copy link
Contributor Author

wrwg commented Dec 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wrwg wrwg enabled auto-merge (squash) December 13, 2024 20:50
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 17230.96 txn/s, latency: 1979.50 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 553320
2. Upgrading first Validator to new version: c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7100.85 txn/s, latency: 3996.29 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 4900 ms), latency samples: 130260
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7315.42 txn/s, latency: 4513.96 ms, (p50: 4800 ms, p70: 4900, p90: 5000 ms, p99: 5000 ms), latency samples: 242580
3. Upgrading rest of first batch to new version: c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2605.50 txn/s, latency: 10921.66 ms, (p50: 12100 ms, p70: 12600, p90: 15000 ms, p99: 15000 ms), latency samples: 48080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7176.43 txn/s, latency: 4587.13 ms, (p50: 4900 ms, p70: 5000, p90: 5200 ms, p99: 5400 ms), latency samples: 235480
4. upgrading second batch to new version: c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10034.56 txn/s, latency: 2780.50 ms, (p50: 2400 ms, p70: 3200, p90: 4600 ms, p99: 4900 ms), latency samples: 182500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10213.62 txn/s, latency: 3123.45 ms, (p50: 2500 ms, p70: 3900, p90: 4800 ms, p99: 5000 ms), latency samples: 341300
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c

two traffics test: inner traffic : committed: 14578.50 txn/s, latency: 2723.29 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5543140
two traffics test : committed: 100.00 txn/s, latency: 1455.61 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 2600 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.559, avg: 1.497", "ConsensusProposalToOrdered: max: 0.333, avg: 0.293", "ConsensusOrderedToCommit: max: 0.382, avg: 0.369", "ConsensusProposalToCommit: max: 0.672, avg: 0.662"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.86s no progress at version 14070 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 2434131 (avg 0.62s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c (PR)
Upgrade the nodes to version: c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1407.80 txn/s, submitted: 1411.12 txn/s, failed submission: 3.32 txn/s, expired: 3.32 txn/s, latency: 2105.14 ms, (p50: 2100 ms, p70: 2300, p90: 2700 ms, p99: 3700 ms), latency samples: 127180
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1482.96 txn/s, submitted: 1486.49 txn/s, failed submission: 3.54 txn/s, expired: 3.54 txn/s, latency: 2014.33 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 3700 ms), latency samples: 134160
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c passed
Upgrade the remaining nodes to version: c449e70d7a2aec601ba983cd7f96fcaf02fa3e5c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1386.19 txn/s, submitted: 1388.68 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2202.96 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4800 ms), latency samples: 122280
Test Ok

@wrwg wrwg merged commit bd71e35 into main Dec 13, 2024
94 checks passed
@wrwg wrwg deleted the wrwg/decomp branch December 13, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario approved these changes

@vineethk vineethk vineethk approved these changes

@banool banool Awaiting requested review from banool banool is a code owner

@rahxephon89 rahxephon89 Awaiting requested review from rahxephon89

@runtian-zhou runtian-zhou Awaiting requested review from runtian-zhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrwg @vineethk @gregnazario