Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SDK] Update CoinClient to address #5648 and #5720 #5723

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

banool
Copy link
Contributor

@banool banool commented Nov 29, 2022

Description

This addresses #5648 and #5720. While I'm here I fix some incorrect documentation on checkBalance, clarify the docs for generating ABIs, and add some more comments to these functions.

Based on a manual inspection and the current / new tests, this should be backwards compatible.

Test Plan

I added new tests, run them like this:

pnpm test

@banool banool force-pushed the banool/coin_client_improvements branch 2 times, most recently from 06b2248 to da1ca3e Compare November 29, 2022 14:56
@banool banool marked this pull request as ready for review November 29, 2022 14:59
@banool
Copy link
Contributor Author

banool commented Nov 29, 2022

@banool banool changed the title [TS SDK] Add getBalance and trasnferCoin functions that address #5648 and #5720 [TS SDK] Update CoinClient to address #5648 and #5720 Nov 29, 2022
@banool banool force-pushed the banool/coin_client_improvements branch from da1ca3e to 075b5bd Compare November 29, 2022 16:18
@banool banool enabled auto-merge (squash) November 29, 2022 18:26
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 075b5bdcf402763c1b536438180ab2241faa41cc

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 075b5bdcf402763c1b536438180ab2241faa41cc (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7257 TPS, 5515 ms latency, 10400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 075b5bdcf402763c1b536438180ab2241faa41cc
compatibility::simple-validator-upgrade::single-validator-upgrade : 5193 TPS, 7901 ms latency, 11000 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 075b5bdcf402763c1b536438180ab2241faa41cc
compatibility::simple-validator-upgrade::half-validator-upgrade : 4187 TPS, 9547 ms latency, 12800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 075b5bdcf402763c1b536438180ab2241faa41cc
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6694 TPS, 5805 ms latency, 9800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 075b5bdcf402763c1b536438180ab2241faa41cc passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 075b5bdcf402763c1b536438180ab2241faa41cc

performance benchmark with full nodes : 6852 TPS, 5776 ms latency, 9900 ms p99 latency,(!) expired 600 out of 2926720 txns
Test Ok

@banool banool merged commit a92815f into main Nov 29, 2022
@banool banool deleted the banool/coin_client_improvements branch November 29, 2022 19:26
@Markuze Markuze mentioned this pull request Dec 5, 2022
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants