Add list of authors to doc pages. #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clay-aptos
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Thank you so much, Zach!
- Is it possible rename at least the list header to Authors?
- Are these errors I'm encountering spurious?
Compiled with problems:X
ERROR in ./src/theme/DocItem/Footer/index.js 1:25-79
Module not found: Error: Can't resolve '@docusaurus/theme-common/internal' in '/Users/claymurphy/aptos-core/developer-docs-site/src/theme/DocItem/Footer'
zacharydenton
force-pushed
the
zach/authors
branch
from
2b59711
to
7f22193
Compare
|
Renamed the list header to "Authors". I made some changes which hopefully fix the build error that you were seeing. Can you try again? |
zacharydenton
force-pushed
the
zach/authors
branch
from
37b9b83
to
e7ca196
Compare
Thank you, @zacharydenton ! This PR no longer triggers a build error locally. Still, I don't see the Authors list locally or at: Sorry if I am missing it. |
clay-aptos
approved these changes
Dec 9, 2022
clay-aptos
requested review from
gregnazario,
movekevin,
bowenyang007,
JoshLind and
wintertoro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
* Add list of authors to doc pages. * Fix build & component title. * Rendering the list doesn't work without DOM.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a list of contributors to every doc page:
Test Plan
yarn start, manually verify list of contributors in docs