[Aptos Framework] Add batch versions of aptos_coin::transfer and transfer_coins #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xchloe
reviewed
Dec 16, 2022
| @@ -40,6 +40,18 @@ module aptos_framework::aptos_account { | |||
| coin::register<AptosCoin>(&signer); | |||
| } | |||
|
|
|||
| /// Batch version of APT transfer. | |||
| public entry fun batch_transfer(source: &signer, recipients: vector<address>, amounts: vector<u64>) { | |||
| let i = 0; | |||
There was a problem hiding this comment.
do we want to assert the vector lengths are the same?
There was a problem hiding this comment.
Updated. It is better to fail explicitly rather than discarding the extra amounts.
movekevin
force-pushed
the
coin-register-2
branch
from
313306e
to
24bd754
Compare
0xchloe
approved these changes
Dec 16, 2022
movekevin
force-pushed
the
coin-register-2
branch
from
24bd754
to
bc77b05
Compare
movekevin
force-pushed
the
coin-register-2
branch
from
bc77b05
to
a72388c
Compare
Added |
lightmark
reviewed
Dec 16, 2022
| ); | ||
|
|
||
| let i = 0; | ||
| let len = vector::length(&recipients); |
There was a problem hiding this comment.
we can save one length() if move this line up before line 75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.