Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aptos-vm] Fix binary format version compatibility. #5898

Merged
merged 2 commits into from
Dec 17, 2022
Merged

[aptos-vm] Fix binary format version compatibility. #5898

merged 2 commits into from
Dec 17, 2022

Conversation

runtian-zhou
Copy link
Contributor

Description

Make sure deserializing module bundles will have the feature flag for v6 file format

Test Plan

TBD.

@runtian-zhou runtian-zhou enabled auto-merge (squash) December 16, 2022 23:32
movekevin
movekevin approved these changes Dec 17, 2022
View reviewed changes
aptos-move/aptos-vm/src/aptos_vm.rs
@@ -481,9 +481,18 @@ impl AptosVM {

/// Deserialize a module bundle.
fn deserialize_module_bundle(&self, modules: &ModuleBundle) -> VMResult<Vec<CompiledModule>> {
let max_version = if self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we track all these places in a list somewhere so next time when we do v7 we remember to update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let’s refactor this piece of code later to make sure we have one single entry.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 512280f0422d60362c73b7fda6fbcc1a5279ed2a

performance benchmark with full nodes : 6263 TPS, 6341 ms latency, 11400 ms p99 latency,(!) expired 320 out of 2674760 txns
Test Ok

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 512280f0422d60362c73b7fda6fbcc1a5279ed2a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 512280f0422d60362c73b7fda6fbcc1a5279ed2a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7176 TPS, 5421 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 512280f0422d60362c73b7fda6fbcc1a5279ed2a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4482 TPS, 8981 ms latency, 11800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 512280f0422d60362c73b7fda6fbcc1a5279ed2a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4700 TPS, 8397 ms latency, 11100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 512280f0422d60362c73b7fda6fbcc1a5279ed2a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6456 TPS, 6041 ms latency, 10000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 512280f0422d60362c73b7fda6fbcc1a5279ed2a passed
Test Ok

@runtian-zhou runtian-zhou merged commit 097931e into main Dec 17, 2022
@runtian-zhou runtian-zhou deleted the runtianz/fix_deser branch December 17, 2022 02:23
runtian-zhou added a commit that referenced this pull request Dec 19, 2022
@runtian-zhou
[aptos-vm] Fix binary format version compatibility. (#5898)
4c4bc64
@runtian-zhou runtian-zhou mentioned this pull request Dec 19, 2022
Merged
runtian-zhou added a commit that referenced this pull request Dec 20, 2022
@runtian-zhou
Cherry Pick PRs (#5930)
79b0872 
* [CI] Adjust the replay verify job (#5849)

* [replay-verify] Add adjust the CI task

* fixup! [replay-verify] Add adjust the CI task

* [aptos-vm] Fix binary format version compatibility. (#5898)
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgao1996 vgao1996 vgao1996 approved these changes

@movekevin movekevin movekevin approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runtian-zhou @vgao1996 @movekevin