Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aptos Framework][Coin standard] Update coin::register to not fail on duplicate registrations #5917

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

movekevin
Copy link
Contributor

Description

This prevents explicit coin::is_account_registered checks to avoid failing coin::register calls due to duplicate registrations.

Test Plan

Unit tests

@movekevin movekevin changed the title [Aptos Framework] Update coin::register to not fail on duplicate registrations [Aptos Framework][Coin standard] Update coin::register to not fail on duplicate registrations Dec 18, 2022
Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should adopt this kind of logic everywhere instead of abort.

@movekevin movekevin enabled auto-merge (squash) December 19, 2022 15:27
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on ab1e0bd0bad8e77ed90522c2424c5759d8862d37

performance benchmark with full nodes : 6391 TPS, 6221 ms latency, 8700 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ab1e0bd0bad8e77ed90522c2424c5759d8862d37

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ab1e0bd0bad8e77ed90522c2424c5759d8862d37 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7534 TPS, 5155 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: ab1e0bd0bad8e77ed90522c2424c5759d8862d37
compatibility::simple-validator-upgrade::single-validator-upgrade : 4673 TPS, 8832 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: ab1e0bd0bad8e77ed90522c2424c5759d8862d37
compatibility::simple-validator-upgrade::half-validator-upgrade : 4833 TPS, 8719 ms latency, 11200 ms p99 latency,no expired txns
4. upgrading second batch to new version: ab1e0bd0bad8e77ed90522c2424c5759d8862d37
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6535 TPS, 6042 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ab1e0bd0bad8e77ed90522c2424c5759d8862d37 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants