-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aptos Framework][Coin standard] Update coin::register to not fail on duplicate registrations #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movekevin
force-pushed
the
coin-register-3
branch
from
December 18, 2022 04:07
6ba31af
to
e29ea4b
Compare
movekevin
changed the title
[Aptos Framework] Update coin::register to not fail on duplicate registrations
[Aptos Framework][Coin standard] Update coin::register to not fail on duplicate registrations
Dec 18, 2022
movekevin
force-pushed
the
coin-register-3
branch
from
December 18, 2022 04:55
e29ea4b
to
27db70e
Compare
davidiw
approved these changes
Dec 18, 2022
movekevin
force-pushed
the
coin-register-3
branch
from
December 19, 2022 08:05
27db70e
to
0f3e6e3
Compare
movekevin
force-pushed
the
coin-register-3
branch
from
December 19, 2022 09:18
0f3e6e3
to
ab1e0bd
Compare
lightmark
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should adopt this kind of logic everywhere instead of abort
.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents explicit coin::is_account_registered checks to avoid failing coin::register calls due to duplicate registrations.
Test Plan
Unit tests