Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas] scale down execution and io gas limit #6837

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Mar 1, 2023

Description

The execution and io gas limits was wrongly inflated because of the GAS_SCALING_FACTOR change.

Test Plan

Added test.

@msmouse msmouse requested review from davidiw, movekevin and a team March 1, 2023 18:27
@msmouse msmouse requested a review from vgao1996 as a code owner March 1, 2023 18:27
Copy link
Contributor

@vgao1996 vgao1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!!!

@msmouse msmouse enabled auto-merge (rebase) March 1, 2023 20:15
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

✅ Forge suite land_blocking success on b91731ab4c6c80e8de212adc58b98580b090af62

performance benchmark with full nodes : 6282 TPS, 6327 ms latency, 10200 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b91731ab4c6c80e8de212adc58b98580b090af62

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b91731ab4c6c80e8de212adc58b98580b090af62 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7664 TPS, 4956 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b91731ab4c6c80e8de212adc58b98580b090af62
compatibility::simple-validator-upgrade::single-validator-upgrade : 4758 TPS, 8728 ms latency, 11900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b91731ab4c6c80e8de212adc58b98580b090af62
compatibility::simple-validator-upgrade::half-validator-upgrade : 4556 TPS, 8557 ms latency, 11800 ms p99 latency,no expired txns
4. upgrading second batch to new version: b91731ab4c6c80e8de212adc58b98580b090af62
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6728 TPS, 5678 ms latency, 10800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b91731ab4c6c80e8de212adc58b98580b090af62 passed
Test Ok

@msmouse msmouse merged commit a543001 into main Mar 1, 2023
@msmouse msmouse deleted the 0301alden_100down branch March 1, 2023 21:01
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

✅ Forge suite framework_upgrade success on cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b91731ab4c6c80e8de212adc58b98580b090af62

Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b91731ab4c6c80e8de212adc58b98580b090af62 (PR)
Upgrade the nodes to version: b91731ab4c6c80e8de212adc58b98580b090af62
framework_upgrade::framework-upgrade::full-framework-upgrade : 7031 TPS, 5389 ms latency, 9300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b91731ab4c6c80e8de212adc58b98580b090af62 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants