Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aptos Framework][Transaction] Add multisig flush Move funcs, txn type (#8411) #8424

Closed
wants to merge 3 commits into from

Conversation

alnoki
Copy link
Contributor

@alnoki alnoki commented May 30, 2023

@banool @chen-robert @lightmark @movekevin

Addresses #8411

  • Adds multisig flush transaction Move flow for DoS mitigation
  • Abstracts functionality to update owners and number of required signatures
  • Adds MultisigFlush API transaction type

@davidiw
Copy link
Contributor

davidiw commented Jun 2, 2023

Thanks for the contribution. Given that this is framework code and impacts network behavior, we'd push this to an AIP first, get feedback from the community, and then evaluate the risk reward for adding it. Curious where you and @movekevin landed on this.

@alnoki
Copy link
Contributor Author

alnoki commented Jun 2, 2023

Thanks for the contribution. Given that this is framework code and impacts network behavior, we'd push this to an AIP first, get feedback from the community, and then evaluate the risk reward for adding it. Curious where you and @movekevin landed on this.

@davidiw #8411 contains a detailed description of the problem this is solving and the rationale for the solution, shall I submit an AIP based on that?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jul 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@alnoki
Copy link
Contributor Author

alnoki commented Sep 6, 2023

Bumping to remove stale label per PR relevance to open aptos-foundation/AIPs#204

@github-actions github-actions bot removed the Stale label Sep 7, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 22, 2023
@github-actions github-actions bot closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants