Return false from areBCSArguments function if array is empty (#221)

* return false from areBCSArguments function if array is empty

* fix typing

.changeset/many-numbers-punch.md

@@ -0,0 +1,5 @@
+---
+"@aptos-labs/wallet-adapter-core": patch
+---
+
+Return false from areBCSArguments function if array is empty

packages/wallet-adapter-core/src/utils/helpers.ts

@@ -1,4 +1,8 @@
-import { Serializable } from "@aptos-labs/ts-sdk";
+import {
+  EntryFunctionArgumentTypes,
+  Serializable,
+  SimpleEntryFunctionArgumentTypes,
+} from "@aptos-labs/ts-sdk";
 
 export function isMobile(): boolean {
   return /Mobile|iP(hone|od|ad)|Android|BlackBerry|IEMobile|Kindle|NetFront|Silk-Accelerated|(hpw|web)OS|Fennec|Minimo|Opera M(obi|ini)|Blazer|Dolfin|Dolphin|Skyfire|Zune/i.test(
@@ -37,6 +41,14 @@ export function generalizedErrorMessage(error: any): string {
 // In @aptos-labs/ts-sdk each move representative class extends
 // Serializable, so if each argument is of an instance of a class
 // the extends Serializable - we know these are BCS arguments
-export const areBCSArguments = (args: any): boolean => {
-  return args.every((arg: any) => arg instanceof Serializable);
+export const areBCSArguments = (
+  args: Array<EntryFunctionArgumentTypes | SimpleEntryFunctionArgumentTypes>
+): boolean => {
+  // `every` returns true if the array is empty, so
+  // first check the array length
+  if (args.length === 0) return false;
+  return args.every(
+    (arg: EntryFunctionArgumentTypes | SimpleEntryFunctionArgumentTypes) =>
+      arg instanceof Serializable
+  );
 };