Handle arguments convertion when submitting a package publish transac…

…tion (#432)

.changeset/new-readers-develop.md

@@ -0,0 +1,5 @@
+---
+"@aptos-labs/wallet-adapter-core": minor
+---
+
+Handle arguments conversion when submitting a package publish transaction

packages/wallet-adapter-core/src/WalletCore.ts

@@ -15,6 +15,7 @@ import {
   generateRawTransaction,
   SimpleTransaction,
   NetworkToChainId,
+  Hex,
 } from "@aptos-labs/ts-sdk";
 import EventEmitter from "eventemitter3";
 import {
@@ -67,6 +68,7 @@ import {
   fetchDevnetChainId,
   generalizedErrorMessage,
   getAptosConfig,
+  handlePublishPackageTransaction,
   isAptosNetwork,
   isRedirectable,
   removeLocalStorage,
@@ -839,6 +841,15 @@ export class WalletCore extends EventEmitter<WalletCoreEvents> {
           throw new WalletSignAndSubmitMessageError("SCAM SITE DETECTED")
             .message;
         }
+
+        if (
+          transactionInput.data.function === "0x1::code::publish_package_txn"
+        ) {
+          ({
+            metadataBytes: transactionInput.data.functionArguments[0],
+            byteCode: transactionInput.data.functionArguments[1],
+          } = handlePublishPackageTransaction(transactionInput));
+        }
       }
 
       this.ensureWalletExists(this._wallet);

packages/wallet-adapter-core/src/utils/helpers.ts

@@ -2,15 +2,20 @@ import {
   Aptos,
   AptosConfig,
   EntryFunctionArgumentTypes,
+  Hex,
   Network,
   NetworkToNodeAPI,
   Serializable,
   SimpleEntryFunctionArgumentTypes,
 } from "@aptos-labs/ts-sdk";
 import { NetworkInfo as StandardNetworkInfo } from "@aptos-labs/wallet-standard";
 import { convertNetwork } from "../LegacyWalletPlugins/conversion";
-import { NetworkInfo } from "../LegacyWalletPlugins/types";
+import {
+  InputTransactionData,
+  NetworkInfo,
+} from "../LegacyWalletPlugins/types";
 import { DappConfig } from "../WalletCore";
+import { WalletSignAndSubmitMessageError } from "../error";
 
 export function isMobile(): boolean {
   return /Mobile|iP(hone|od|ad)|Android|BlackBerry|IEMobile|Kindle|NetFront|Silk-Accelerated|(hpw|web)OS|Fennec|Minimo|Opera M(obi|ini)|Blazer|Dolfin|Dolphin|Skyfire|Zune/i.test(
@@ -110,3 +115,35 @@ export const fetchDevnetChainId = async (): Promise<number> => {
   const aptos = new Aptos(); // default to devnet
   return await aptos.getChainId();
 };
+
+/**
+ * A helper function to handle the publish package transaction.
+ * The Aptos SDK expects the metadataBytes and byteCode to be Uint8Array, but in case the arguments are passed in
+ * as a string, this function converts the string to Uint8Array.
+ */
+export const handlePublishPackageTransaction = (
+  transactionInput: InputTransactionData
+) => {
+  // convert the first argument, metadataBytes, to uint8array if is a string
+  let metadataBytes = transactionInput.data.functionArguments[0];
+  if (typeof metadataBytes === "string") {
+    metadataBytes = Hex.fromHexInput(metadataBytes).toUint8Array();
+  }
+
+  // convert the second argument, byteCode, to uint8array if is a string
+  let byteCode = transactionInput.data.functionArguments[1];
+  if (Array.isArray(byteCode)) {
+    byteCode = byteCode.map((byte) => {
+      if (typeof byte === "string") {
+        return Hex.fromHexInput(byte).toUint8Array();
+      }
+      return byte;
+    });
+  } else {
+    throw new WalletSignAndSubmitMessageError(
+      "The bytecode argument must be an array."
+    ).message;
+  }
+
+  return { metadataBytes, byteCode };
+};