Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sender optional when sign and submit single signer transaction #208

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Make sender optional when sign and submit single signer transaction #208

merged 1 commit into from
Dec 5, 2023

Conversation

0xmaayan
Copy link
Collaborator

@0xmaayan 0xmaayan commented Dec 5, 2023

sender prop should not be required by the dapp to provide when sign and submit a single signer transaction, this PR makes it an optional prop and if not provided the adapter would take care for it

@gregnazario gregnazario merged commit ed8fcdc into main Dec 5, 2023
6 checks passed
@gregnazario gregnazario deleted the omit_sender_prop branch December 5, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario approved these changes

@banool banool Awaiting requested review from banool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmaayan @gregnazario