New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate `options` argument on `signAndSubmitTransaction` #210

Merged

gregnazario merged 1 commit into main from options_argument

Dec 7, 2023

Collaborator

0xmaayan commented Dec 7, 2023

signAndSubmitTransaction function arguments accepts the options argument in multiple ways

As part of the transaction argument object
As a second argument

This PR consolidates the argument an is now part of the transaction argument object
Should fix #209


          consolidate options argument on signAndSubmitTransaction

6266a29

0xmaayan requested review from gregnazario and banool as code owners

December 7, 2023 16:51

0xmaayan mentioned this pull request

Bug: maxGasAmount not work correctly #209

Closed

gregnazario approved these changes

View reviewed changes

gregnazario merged commit 08fb838 into main

6 checks passed

gregnazario deleted the options_argument branch

December 7, 2023 19:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet