-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added a Back-To Home Button on The Login Page #1029
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RadhikaMalpani1702! Thank you for your valuable contribution! Our team will review it and get back to you soon.
Hey @RadhikaMalpani1702, the position for the home icon is not good, Try adding a left arrow in a circle instead of home icon on the left side of the title Tour Guide with some proper padding and all, it will look more great there |
Hey @itsekta I am unable to change the position because it is breaking the login page |
Hey @RadhikaMalpani1702, for a good UI the position is not best for the arrow, what are the breaking changes as i have tried the same and it's working. Try one more time, If you are still facing any issue let connect over discord just ping me there. |
@RadhikaMalpani1702 are you still working on this? |
@itsekta Yes I wil resolved today itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RadhikaMalpani1702 I have reviewed it & as per the changes @itsekta has suggested its working well . I have approved this
now , ma'am @itsekta I request u to please review this PR also so that I can merge it under GSSOC'24 |
@itsekta Please review it. |
@apu52 If you have already reviewed it then please merge it |
@RadhikaMalpani1702 I have merged it |
Title and Issue number
Issue fixes : #1018
Description
Hey @itsekta and @apu52
I have added a Back-To-Home Button on The Login Page.
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24
VSOC'24