Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a Back-To Home Button on The Login Page #1029

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

RadhikaMalpani1702
Copy link
Contributor

Title and Issue number

Issue fixes : #1018

Description

Hey @itsekta and @apu52

I have added a Back-To-Home Button on The Login Page.

Video/Screenshots (mandatory)

image

Type of PR

  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit a13d5a0
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66978d924ab09000080e2e22
😎 Deploy Preview https://deploy-preview-1029--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RadhikaMalpani1702! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@RadhikaMalpani1702 RadhikaMalpani1702 changed the title Added a Back-To Home Button on The Login Page feat: Added a Back-To Home Button on The Login Page Jul 8, 2024
@itsekta
Copy link
Collaborator

itsekta commented Jul 9, 2024

Hey @RadhikaMalpani1702, the position for the home icon is not good, Try adding a left arrow in a circle instead of home icon on the left side of the title Tour Guide with some proper padding and all, it will look more great there

Screenshot 2024-07-09 071356

@RadhikaMalpani1702
Copy link
Contributor Author

Hey @itsekta

I am unable to change the position because it is breaking the login page
Is this okay?

image

@itsekta
Copy link
Collaborator

itsekta commented Jul 9, 2024

Hey @RadhikaMalpani1702, for a good UI the position is not best for the arrow, what are the breaking changes as i have tried the same and it's working. Try one more time, If you are still facing any issue let connect over discord just ping me there.

@apu52 apu52 requested a review from itsekta July 14, 2024 07:08
@apu52 apu52 added the question Further information is requested label Jul 14, 2024
@itsekta
Copy link
Collaborator

itsekta commented Jul 15, 2024

@RadhikaMalpani1702 are you still working on this?

@RadhikaMalpani1702
Copy link
Contributor Author

RadhikaMalpani1702 commented Jul 15, 2024

@itsekta Yes I wil resolved today itself

@RadhikaMalpani1702
Copy link
Contributor Author

@itsekta and @apu52 Changes are done please merge this PR

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RadhikaMalpani1702 I have reviewed it & as per the changes @itsekta has suggested its working well . I have approved this

@apu52
Copy link
Owner

apu52 commented Jul 17, 2024

now , ma'am @itsekta I request u to please review this PR also so that I can merge it under GSSOC'24

@apu52 apu52 added enhancement New feature or request WAITING gssoc and removed question Further information is requested labels Jul 17, 2024
@RadhikaMalpani1702
Copy link
Contributor Author

@itsekta Please review it.

@RadhikaMalpani1702
Copy link
Contributor Author

@apu52 If you have already reviewed it then please merge it

@apu52 apu52 merged commit c503159 into apu52:main Jul 19, 2024
6 checks passed
@apu52 apu52 added level1 and removed WAITING labels Jul 19, 2024
@apu52
Copy link
Owner

apu52 commented Jul 19, 2024

@RadhikaMalpani1702 I have merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Back-To Home Button on The Login Page
3 participants