Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google logo Adjustment #1114

Merged
merged 3 commits into from
Jul 20, 2024
Merged

feat: Google logo Adjustment #1114

merged 3 commits into from
Jul 20, 2024

Conversation

AshmitaBarthwal
Copy link
Contributor

Title and Issue number

Title : Google logo Adjustment

Issue No. : #1085

Code Stack : CSS

Close #1085

Description

Made the changes to the google logo as it was not visible for good user experience.

Video/Screenshots (mandatory)

BEFORE:
Screenshot 2024-07-15 234255
AFTER:
Screenshot 2024-07-16 183623

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 51a07e8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66979b617ea28d00085d3169
😎 Deploy Preview https://deploy-preview-1114--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Please Review my pull request.
You have asked to make the new pull request and I have made this new Pull request.

@AshmitaBarthwal
Copy link
Contributor Author

@itsekta Please review my pull request once.

@itsekta
Copy link
Collaborator

itsekta commented Jul 19, 2024

Hey @AshmitaBarthwal, your changes looks good, the PR will be merged asap

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Review it once.

@apu52 apu52 merged commit 0402aff into apu52:main Jul 20, 2024
6 checks passed
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshmitaBarthwal though I have merged it why this commit is present in this PR as it is unnecessary , as it's relatable for the other issues PR , Ok from next time for different issue/PR make different branches in your forked repo & make your commits differently in those branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google logo adjustment
3 participants