Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trip Gallery Page is Been Updated #946

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Conversation

AbheetHacker4278
Copy link
Contributor

@AbheetHacker4278 AbheetHacker4278 commented Jun 29, 2024

Title and Issue number

Title :

[Feature Request]: Trip Gallery Changes

Issue No. :
#925

Code Stack :

Close #925

Description

Here in this PR i have do some of the major changes in Trip Gallery , i have improved the User Interface of the Page , by using cool animation , so due to this the experience of the users also get enhanced.

Video/Screenshots (mandatory)

BEFORE
Screenshot 2024-06-27 230043

AFTER
image

Video

18-04-37.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

@apu52 please review this PR and merge with main branch under Gssoc24

##Are you contributing under any Open-source programme?

#GSSOC24

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit a395ae3
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669c7d93282c8c0008171055
😎 Deploy Preview https://deploy-preview-946--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AbheetHacker4278 AbheetHacker4278 changed the title Trip Gallery Page is Been Updated feat: Trip Gallery Page is Been Updated Jun 29, 2024
@itsekta
Copy link
Collaborator

itsekta commented Jun 30, 2024

Hey @AbheetHacker4278, can you add an overlay layer on these card images so that the content on the images will be move visible on hovering on it

@AbheetHacker4278
Copy link
Contributor Author

Hey @AbheetHacker4278, can you add an overlay layer on these card images so that the content on the images will be move visible on hovering on it

Okay i will do it

added Overlays when hover for more detail view of the image
@AbheetHacker4278
Copy link
Contributor Author

@itsekta I have done the necessary changes , please review it and merge it with main branch

@AbheetHacker4278
Copy link
Contributor Author

@itsekta please also add Gssoc labels with level 2

@AbheetHacker4278
Copy link
Contributor Author

@itsekta if you like the changes please merge with main branch

@AbheetHacker4278
Copy link
Contributor Author

@itsekta @apu52 please merge into main branch if there is no errors

@itsekta
Copy link
Collaborator

itsekta commented Jul 2, 2024

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

@AbheetHacker4278
Copy link
Contributor Author

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Okay i will do that in new PR , Because this take some time and i also have to re structure the code base from start to end , so better you merge this pr with main branch and tommorow i will open an new issue you just approve it, is it fine.

@AbheetHacker4278
Copy link
Contributor Author

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Because code base are in very bad structure very messy , thats why i am asking you

@AbheetHacker4278
Copy link
Contributor Author

AbheetHacker4278 commented Jul 2, 2024

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Please merge this PR , tommorow i will open new issue and accept it also 🙏

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbheetHacker4278 the changes u have made are really cool

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

but here I can see there is a bug in your Deployed pR , please try to resolve this So that I can merge your PR

@apu52 apu52 added help wanted Extra attention is needed and removed level2 gssoc labels Jul 3, 2024
@AbheetHacker4278
Copy link
Contributor Author

image

but here I can see there is a bug in your Deployed pR , please try to resolve this So that I can merge your PR

I havent see any kind of bugs from my side , please check it again please. and i think , this is not my PR sir.

image

@AbheetHacker4278
Copy link
Contributor Author

image

but here I can see there is a bug in your Deployed pR , please try to resolve this So that I can merge your PR

@apu52
Copy link
Owner

apu52 commented Jul 5, 2024

image
but here I can see there is a bug in your Deployed pR , please try to resolve this So that I can merge your PR

I havent see any kind of bugs from my side , please check it again please. and i think , this is not my PR sir.

image

not this changes what u have made .the above image slider is facing some bugs

@AbheetHacker4278
Copy link
Contributor Author

@apu52 all bugs is been removed , please review it and merge it with main branch

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbheetHacker4278 all the changes are really good

@apu52 apu52 merged commit aee06d1 into apu52:main Jul 21, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level2 gssoc and removed help wanted Extra attention is needed labels Jul 21, 2024
@apu52
Copy link
Owner

apu52 commented Jul 21, 2024

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Okay i will do that in new PR , Because this take some time and i also have to re structure the code base from start to end , so better you merge this pr with main branch and tommorow i will open an new issue you just approve it, is it fine.

I have merged the previous PR , have u raised a new issue what @itsekta ma'am has already suggested u ?? if not please raise it so that u will get assigned

@AbheetHacker4278
Copy link
Contributor Author

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well

Okay i will do that in new PR , Because this take some time and i also have to re structure the code base from start to end , so better you merge this pr with main branch and tommorow i will open an new issue you just approve it, is it fine.

I have merged the previous PR , have u raised a new issue what @itsekta ma'am has already suggested u ?? if not please raise it so that u will get assigned

Okay , in 2 days i will do it , because my exams are starting , so after that i will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Trip Gallery Changes
3 participants