-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trip Gallery Page is Been Updated #946
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @AbheetHacker4278, can you add an overlay layer on these card images so that the content on the images will be move visible on hovering on it |
Okay i will do it |
added Overlays when hover for more detail view of the image
@itsekta I have done the necessary changes , please review it and merge it with main branch |
@itsekta please also add Gssoc labels with level 2 |
@itsekta if you like the changes please merge with main branch |
Hey, @AbheetHacker4278 can you also make it responsive for mobile screen as well |
Okay i will do that in new PR , Because this take some time and i also have to re structure the code base from start to end , so better you merge this pr with main branch and tommorow i will open an new issue you just approve it, is it fine. |
Because code base are in very bad structure very messy , thats why i am asking you |
Please merge this PR , tommorow i will open new issue and accept it also 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbheetHacker4278 the changes u have made are really cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apu52 all bugs is been removed , please review it and merge it with main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbheetHacker4278 all the changes are really good
I have merged the previous PR , have u raised a new issue what @itsekta ma'am has already suggested u ?? if not please raise it so that u will get assigned |
Okay , in 2 days i will do it , because my exams are starting , so after that i will do it |
Title and Issue number
Title :
[Feature Request]: Trip Gallery Changes
Issue No. :
#925
Code Stack :
Close #925
Description
Here in this PR i have do some of the major changes in Trip Gallery , i have improved the User Interface of the Page , by using cool animation , so due to this the experience of the users also get enhanced.
Video/Screenshots (mandatory)
BEFORE
AFTER
Video
18-04-37.mp4
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
@apu52 please review this PR and merge with main branch under Gssoc24
##Are you contributing under any Open-source programme?
#GSSOC24
GSSOC'24
VSOC'24