Update deployments yamls with new fields in KE configmap. #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mjshastha
force-pushed
the
simplifyDeployConfig
branch
2 times, most recently
from
7aae2ff
to
17e9689
Compare
KiranBodipi
added a commit
to KiranBodipi/deployments
that referenced
this pull request
May 16, 2024
With this change, we are replacing starboard operator with trivy operator 1. We have updated kube_enforcer,kube_enforcer_advanced manifest files with Trivy Operator Resources 2. Moved starboard manifest files to kube_enforcer_starbaord and kube_enforcer_advanced_starboard 3. Updated relevant gen_ke_certs.sh and readme files Reference PR: aquasecurity#566 4. Upgraded trivy-operator version to latest (0.20.1)as the existing version has critical vulnerabilities 5. Upgraded kube-bench version with latest (v0.7.3) Reference PR: aquasecurity#567 6. Added keys for Admission Control when the GW is disconnected, Enable workload discovery, Register discovered pod images, and Add discovered registries. 7. Removed the AQUA_WATCH_CONFIG_AUDIT_REPORT key as it is no longer supported. Reference PR: aquasecurity#565
mjshastha
force-pushed
the
simplifyDeployConfig
branch
from
17e9689
to
d9c4b6e
Compare
deven0t
approved these changes
May 29, 2024
KiranBodipi
reviewed
May 29, 2024
| @@ -90,8 +90,14 @@ spec: | |||
| # Enable KA policy scanning via Trivy-Operator | |||
| - name: AQUA_KAP_ADD_ALL_CONTROL | |||
| value: "true" | |||
| - name: AQUA_WATCH_CONFIG_AUDIT_REPORT | |||
| - name: AQUA_ADMISSION_CONTROL_WHEN_GW_DISCONNECTED | |||
There was a problem hiding this comment.
@ManojShastha Can you check if we need to add the property AQUA_ME_GW_CERT_SECRET_NAME in the Trivy-related deployment files? I noticed this property is included in the Starboard deployment files.
mjshastha
force-pushed
the
simplifyDeployConfig
branch
from
d9c4b6e
to
f4e3a73
Compare
mjshastha
force-pushed
the
simplifyDeployConfig
branch
from
f4e3a73
to
127cf9b
Compare
deven0t
approved these changes
Jul 30, 2024
…sconnected, Enable workload discovery, Register discovered pod images, and Add discovered registries. Additionally, removed the AQUA_WATCH_CONFIG_AUDIT_REPORT key as it is no longer supported.
mjshastha
force-pushed
the
simplifyDeployConfig
branch
from
127cf9b
to
0820285
Compare
|
@semyonmor Can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this update, included keys for Admission Control when the GW is disconnected, Enable workload discovery, Register discovered pod images, and Add discovered registries.
Additionally, removed the AQUA_WATCH_CONFIG_AUDIT_REPORT key as it is no longer supported.
ref: 7641f53