Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Maven dependency.txt #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

masahiro331
Copy link
Collaborator

@masahiro331 masahiro331 commented May 16, 2021

In the case of such "aggregate pom", no dependency is output.
https://github.com/apache/hadoop/tree/trunk/hadoop-cloud-storage-project

@masahiro331 masahiro331 marked this pull request as draft May 16, 2021 08:43
@masahiro331 masahiro331 self-assigned this May 20, 2021
@masahiro331 masahiro331 marked this pull request as ready for review May 20, 2021 01:18
pkg/maven/pom.xml Outdated Show resolved Hide resolved
Comment on lines 85 to 87
case 5:
artifact.Version = ss[3]
artifact.Scope = ss[4]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ss[4] might be a version.

pkg/maven/parse.go Outdated Show resolved Hide resolved
pkg/maven/parse.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants