Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse java php nodejs binary version #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

laurentdelosieresmano
Copy link

Hello,

This PR parses the versions of standalone binaries (PHP / Java / Node.js) that are extracted from tarballs and not packages. Let me know if you wish to add more conditions to avoid false positives. Unfortunately, the filename was not passed to the "Parse()" function; otherwise, I could have added an extra condition on the filename (e.g. if the file starts with "java", or "node").

This resolves aquasecurity/trivy#1064.

Best,
Laurent

@bhbitter
Copy link

What is the status of merging this feature? I have the same issue where trivy doesn't report the vulnerable version of nodejs.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2021

CLA assistant check
All committers have signed the CLA.

@dasmfm
Copy link

dasmfm commented Feb 14, 2024

This PR could be really useful, right now trivy can't detect that, i.e., PHP version contains vulnerabilities.

trivy image php:8.1.16-zts-alpine3.17 - no php in output

But there are some in PHP 8.1.16:
https://nvd.nist.gov/vuln/detail/CVE-2023-3824

@kovacs-levent
Copy link

Same is also happening for Python binaries, this feature of scanning standalone binaries would be helpful in general... Encountered the issue while generating SBOMs with trivy aquasecurity/trivy#6457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trivy is not scanning standalone java / nodejs / PHP binaries
5 participants