Parse java php nodejs binary version #35
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR parses the versions of standalone binaries (PHP / Java / Node.js) that are extracted from tarballs and not packages. Let me know if you wish to add more conditions to avoid false positives. Unfortunately, the filename was not passed to the "Parse()" function; otherwise, I could have added an extra condition on the filename (e.g. if the file starts with "java", or "node").
This resolves aquasecurity/trivy#1064.
Best,
Laurent