Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prog): Add autoattach api #406

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

chentao-kernel
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

@chentao-kernel
Copy link
Contributor Author

Add it!

@geyslan
Copy link
Member

geyslan commented Mar 11, 2024

@chentao-kernel thank you for your contribution. Would you mind creating a selftest for this new API? You could follow this lead: https://github.com/aquasecurity/libbpfgo/tree/main/selftest/set-attach

@chentao-kernel
Copy link
Contributor Author

@chentao-kernel thank you for your contribution. Would you mind creating a selftest for this new API? You could follow this lead: https://github.com/aquasecurity/libbpfgo/tree/main/selftest/set-attach

hi,geyslan, no problem, i will do it latter, thank you for your reply!

@chentao-kernel chentao-kernel force-pushed the dylane/autoattach branch 2 times, most recently from 3a256f4 to 7279938 Compare March 11, 2024 14:58
@chentao-kernel
Copy link
Contributor Author

@chentao-kernel thank you for your contribution. Would you mind creating a selftest for this new API? You could follow this lead: https://github.com/aquasecurity/libbpfgo/tree/main/selftest/set-attach

hi,geyslan, no problem, i will do it latter, thank you for your reply!

done, i also add

@chentao-kernel thank you for your contribution. Would you mind creating a selftest for this new API? You could follow this lead: https://github.com/aquasecurity/libbpfgo/tree/main/selftest/set-attach

hi,geyslan, no problem, i will do it latter, thank you for your reply!

done!

Signed-off-by: Tao Chen <chen.dylane@gmail.com>
Co-authored-by: Geyslan Gregório <geyslan@gmail.com>
@geyslan geyslan self-assigned this Mar 11, 2024
@geyslan geyslan added the feature New feature or request label Mar 11, 2024
@geyslan
Copy link
Member

geyslan commented Mar 13, 2024

@chentao-kernel I've requested a pull from you in your own branch (changing the way it tests). Do you mind update it and push force? Thanks.

@chentao-kernel
Copy link
Contributor Author

chentao-kernel commented Mar 14, 2024

@chentao-kernel I've requested a pull from you in your own branch (changing the way it tests). Do you mind update it and push force? Thanks.
hi, geyslan, thank you for your review, i merge it in my branch and update it.

@geyslan
Copy link
Member

geyslan commented Mar 14, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chentao-kernel I think you miss that. After signing the CLA I can merge the PR.

@chentao-kernel
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chentao-kernel I think you miss that. After signing the CLA I can merge the PR.

Excuse me, now finished.

@chentao-kernel
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chentao-kernel I think you miss that. After signing the CLA I can merge the PR.

Excuse me, now finished.

hi,geyslan, i saw the libbpf released some new feature, so libbpfgo developed base on the latest libbpf version or
specify version, maybe i can participate in more development tasks.

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 6d28299 into aquasecurity:main Mar 14, 2024
14 checks passed
@geyslan
Copy link
Member

geyslan commented Mar 14, 2024

hi,geyslan, i saw the libbpf released some new feature, so libbpfgo developed base on the latest libbpf version or
specify version, maybe i can participate in more development tasks.

Feel free to pick some open issue or bring us new API functionalities.

Thank you for your contribution. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants