Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0: Fix paths for scripts #63

Closed
wants to merge 1 commit into from
Closed

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Nov 6, 2020

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #63 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   21.39%   20.93%   -0.47%     
==========================================
  Files           4        4              
  Lines         187      172      -15     
==========================================
- Hits           40       36       -4     
+ Misses        144      133      -11     
  Partials        3        3              
Impacted Files Coverage Δ
app.go 24.28% <0.00%> (-2.04%) ⬇️
main.go 0.00% <0.00%> (ø)
utils.go 0.00% <0.00%> (ø)
root.go 61.29% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3954e...b0be9b4. Read the comment docs.

@yoavrotems
Copy link
Contributor

Hey! Thanks for that, it is a right fix, but we changed the engine in bench-common now to support shell scripts in audit field, so those are no longer necessary, thanks for contributing but I'm closing this one.
You can see the changes in: aquasecurity/bench-common#108
And I made a draft PR in here about those changes: #64

@yoavrotems yoavrotems closed this Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants