Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit the num of failure entries in compliance detail report #1108

Conversation

chen-keinan
Copy link
Contributor

@chen-keinan chen-keinan commented Apr 4, 2022

Signed-off-by: chenk hen.keinan@gmail.com

Description

This change limits the number of fail entries per control check in the cluster compliance detail report.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1108 (0c06bab) into main (38a0b16) will increase coverage by 0.03%.
The diff coverage is 73.52%.

❗ Current head 0c06bab differs from pull request most recent head f821575. Consider uploading reports for the commit f821575 to get more accurate results

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   58.01%   58.05%   +0.03%     
==========================================
  Files          71       71              
  Lines        9268     9290      +22     
==========================================
+ Hits         5377     5393      +16     
- Misses       3347     3351       +4     
- Partials      544      546       +2     
Impacted Files Coverage Δ
pkg/compliance/clustercompliancereport.go 40.00% <ø> (ø)
pkg/cmd/get_clustercompliancereport.go 47.25% <33.33%> (-2.15%) ⬇️
pkg/starboard/config.go 72.76% <81.25%> (+0.25%) ⬆️
pkg/compliance/io.go 92.03% <100.00%> (+0.07%) ⬆️
pkg/operator/operator.go 55.02% <100.00%> (-0.22%) ⬇️
pkg/vulnerabilityreport/controller.go 55.79% <0.00%> (-3.05%) ⬇️
pkg/operator/controller/ciskubebenchreport.go 56.17% <0.00%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5855a...f821575. Read the comment docs.

@chen-keinan chen-keinan marked this pull request as ready for review April 4, 2022 14:00
@chen-keinan chen-keinan requested review from danielpacak and removed request for danielpacak April 4, 2022 14:02
@chen-keinan chen-keinan force-pushed the fix/limit-num-failure-entries-compliance-report branch from 16dc47d to 07460b2 Compare April 4, 2022 16:23
Signed-off-by: chenk <hen.keinan@gmail.com>
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan chen-keinan force-pushed the fix/limit-num-failure-entries-compliance-report branch from 07460b2 to 88262f9 Compare April 5, 2022 13:47
deploy/helm/values.yaml Outdated Show resolved Hide resolved
docs/operator/configuration.md Outdated Show resolved Hide resolved
pkg/cmd/get_clustercompliancereport.go Outdated Show resolved Hide resolved
pkg/cmd/get_clustercompliancereport.go Outdated Show resolved Hide resolved
pkg/compliance/clustercompliancereport_test.go Outdated Show resolved Hide resolved
pkg/compliance/io.go Show resolved Hide resolved
pkg/compliance/io.go Outdated Show resolved Hide resolved
@chen-keinan chen-keinan force-pushed the fix/limit-num-failure-entries-compliance-report branch 2 times, most recently from e28f7a2 to 76bd44a Compare April 5, 2022 18:48
@chen-keinan chen-keinan added this to the 0.15.2 milestone Apr 6, 2022
@chen-keinan chen-keinan added the 🐛 bug Something isn't working label Apr 6, 2022
deploy/helm/values.yaml Outdated Show resolved Hide resolved
pkg/cmd/get_clustercompliancereport.go Show resolved Hide resolved
pkg/cmd/get_clustercompliancereport.go Show resolved Hide resolved
pkg/compliance/clustercompliancereport_test.go Outdated Show resolved Hide resolved
pkg/compliance/clustercompliancereport_test.go Outdated Show resolved Hide resolved
pkg/compliance/io.go Show resolved Hide resolved
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan chen-keinan force-pushed the fix/limit-num-failure-entries-compliance-report branch from 0c06bab to f821575 Compare April 6, 2022 08:20
@chen-keinan chen-keinan merged commit cb5f3b3 into aquasecurity:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the num of failure entries per control check in cluster compliance detail report
2 participants