perf: Optimize cache by minimizing unnecessary data storage. #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjshastha
force-pushed
the
SBOptmizations
branch
5 times, most recently
from
999f3b5 to
cd11a43
Compare
mjshastha
force-pushed
the
SBOptmizations
branch
4 times, most recently
from
8d0f906 to
914b2e8
Compare
mjshastha
force-pushed
the
SBOptmizations
branch
9 times, most recently
from
cb0f499 to
67e1d0f
Compare
mjshastha
force-pushed
the
SBOptmizations
branch
4 times, most recently
from
04de140 to
4d7ff27
Compare
…ug fixes, and memory optimization. Stripped managed fields and last-applied-configuration from resources and cache: Implemented object metadata transformation using `WithTransform` in `NewSharedInformerFactoryWithOptions` for shared informers. ref: informers package - k8s.io/client-go/informers - Go Packages Updated the controller runtime manager cache to include `DefaultTransform`, leveraging `TransformStripManagedFields()` along with logic to remove the last-applied-configuration annotation for all cached objects. ref: cache package - sigs.k8s.io/controller-runtime/pkg/cache - Go Packages These changes ensure that unwanted metadata is removed from objects before they are stored in the cache, optimizing memory usage and improving performance.
mjshastha
force-pushed
the
SBOptmizations
branch
from
4d7ff27 to
346a38a
Compare
deven0t
reviewed
Dec 11, 2024
| @@ -36,34 +35,6 @@ type Inputs struct { | |||
| func VulnerabilityScannerBehavior(inputs *Inputs) func() { | |||
| return func() { | |||
|
|
|||
| Context("When unmanaged Pod is created", func() { | |||
There was a problem hiding this comment.
any reason to remove this test case
| @@ -79,15 +50,15 @@ func VulnerabilityScannerBehavior(inputs *Inputs) func() { | |||
|
|
|||
| err := inputs.Create(ctx, deploy) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Eventually(inputs.HasActiveReplicaSet(inputs.PrimaryNamespace, deploy.Name), inputs.AssertTimeout).Should(BeTrue()) | |||
| Eventually(inputs.HasActiveReplicaSet(inputs.PrimaryNamespace, deploy.Name), 300*time.Second).Should(BeTrue()) | |||
There was a problem hiding this comment.
I see we are updating AssertTimeout to 5min, so we dont need this change here. Let it come from inputs.Asserttimeout
There was a problem hiding this comment.
will address in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to controller-runtime and client-go for better performance, bug fixes, and memory optimization.
Stripped managed fields and last-applied-configuration from resources and cache:
WithTransforminNewSharedInformerFactoryWithOptionsfor shared informers. ref: informers package - k8s.io/client-go/informers - Go PackagesDefaultTransform, leveragingTransformStripManagedFields()along with logic to remove the last-applied-configuration annotation for all cached objects. ref: cache package - sigs.k8s.io/controller-runtime/pkg/cache - Go PackagesAdditionally, fixed failing unit test cases.