Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint) : setup golangci-lint #845

Merged
merged 1 commit into from
Dec 10, 2021
Merged

ci(lint) : setup golangci-lint #845

merged 1 commit into from
Dec 10, 2021

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #845 (6d7b196) into main (83627b3) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

❗ Current head 6d7b196 differs from pull request most recent head 96fd48f. Consider uploading reports for the commit 96fd48f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   65.83%   65.74%   -0.10%     
==========================================
  Files          58       58              
  Lines        6454     6454              
==========================================
- Hits         4249     4243       -6     
- Misses       1778     1782       +4     
- Partials      427      429       +2     
Impacted Files Coverage Δ
pkg/cmd/get_configauditreports.go 32.83% <0.00%> (ø)
pkg/cmd/get_vulnerabilityreports.go 60.63% <0.00%> (ø)
pkg/starboard/plugin.go 53.33% <ø> (ø)
pkg/plugin/conftest/plugin.go 78.70% <100.00%> (ø)
pkg/plugin/polaris/plugin.go 82.55% <100.00%> (ø)
pkg/plugin/trivy/plugin.go 82.78% <100.00%> (ø)
pkg/operator/controller/ciskubebenchreport.go 57.64% <0.00%> (-1.32%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 63.63% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83627b3...96fd48f. Read the comment docs.

@danielpacak danielpacak self-requested a review December 10, 2021 13:08
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this PR @mmorel-35 Overall it looks good to me. I only suggested reusing existing workflow definition file to add linter step.

Please squash and sign-off your commits as well.

.github/workflows/publish-helm-chart.yaml Show resolved Hide resolved
@@ -0,0 +1,23 @@
name: Golangci-lint
Copy link
Contributor

@danielpacak danielpacak Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .github/workflow/build.yaml we already defined a workflow to do static analysis of source code on each PR.
Instead of adding another YAML, could we run golangci-lint action as a step under the verify-code job? This way we'll group checks and workflow triggers in one place.

Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@danielpacak danielpacak self-requested a review December 10, 2021 14:26
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments @mmorel-35 🚀

@danielpacak danielpacak merged commit 09283fd into aquasecurity:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants