-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(lint) : setup golangci-lint #845
Conversation
Codecov Report
@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 65.83% 65.74% -0.10%
==========================================
Files 58 58
Lines 6454 6454
==========================================
- Hits 4249 4243 -6
- Misses 1778 1782 +4
- Partials 427 429 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this PR @mmorel-35 Overall it looks good to me. I only suggested reusing existing workflow definition file to add linter step.
Please squash and sign-off your commits as well.
.github/workflows/golangci-lint.yml
Outdated
@@ -0,0 +1,23 @@ | |||
name: Golangci-lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In .github/workflow/build.yaml
we already defined a workflow to do static analysis of source code on each PR.
Instead of adding another YAML, could we run golangci-lint action as a step under the verify-code
job? This way we'll group checks and workflow triggers in one place.
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments @mmorel-35 🚀
No description provided.