Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PET-1192 - Add image subcommand to trivy plugin #891

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

Arabus
Copy link
Contributor

@Arabus Arabus commented Jan 8, 2022

Fixes #888

Had to reorder the args a little because --skip-update belongs to the
image subcommand now

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2022

CLA assistant check
All committers have signed the CLA.

@danielpacak
Copy link
Contributor

@Arabus Thank you for working on this patch. I think we must update Go tests as well. You can check locally with make unit-tests that there are no failures.

Fixes aquasecurity#888

Had to reorder the args a little because -skip-update belongs to the
image subcommand now
@Arabus
Copy link
Contributor Author

Arabus commented Jan 10, 2022

Tests light up all green for me locally so i guess the changes made work. I also updated the comments in the plugin.go to reflect the proper command order. Please have another look when you find the time. 🙏

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #891 (5cead2b) into main (5ab3973) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   65.56%   65.61%   +0.04%     
==========================================
  Files          58       58              
  Lines        6488     6514      +26     
==========================================
+ Hits         4254     4274      +20     
- Misses       1804     1805       +1     
- Partials      430      435       +5     
Impacted Files Coverage Δ
pkg/plugin/trivy/plugin.go 82.31% <100.00%> (+0.04%) ⬆️
pkg/operator/controller/vulnerabilityreport.go 61.48% <0.00%> (-1.46%) ⬇️
pkg/operator/etc/config.go 75.75% <0.00%> (ø)
pkg/kube/object.go 60.40% <0.00%> (+0.76%) ⬆️
pkg/operator/controller/configauditreport.go 65.88% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab3973...5cead2b. Read the comment docs.

@danielpacak danielpacak added this to the Release v0.14.0 milestone Jan 11, 2022
@danielpacak danielpacak self-requested a review January 11, 2022 08:46
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks you @Arabus !

@danielpacak danielpacak merged commit 8b46e5b into aquasecurity:main Jan 11, 2022
@Arabus Arabus deleted the PET-1192 branch January 11, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starboard uses deprecated trivy cmd invocation
3 participants