Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: take v1.Image as input #21

Merged
merged 2 commits into from
Jul 30, 2024
Merged

feat: take v1.Image as input #21

merged 2 commits into from
Jul 30, 2024

Conversation

knqyf263
Copy link
Collaborator

tarball.Image() is not flexible; it cannot set a custom media type and configure compressed/uncompressed. Taking v1.Image as input instead of string allows more flexible OCI artifacts to be tested (e.g., attestations).

NOTE: This PR is on top of #20, which must be merged first.

knqyf263 added 2 commits July 29, 2024 16:04
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 requested a review from DmitriyLewen July 29, 2024 13:44
@knqyf263 knqyf263 self-assigned this Jul 29, 2024
Base automatically changed from multiple_imgs to main July 30, 2024 03:53
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 merged commit 4642e94 into main Jul 30, 2024
5 checks passed
@knqyf263 knqyf263 deleted the v1_img branch July 30, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants