Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 support, switch to latest alpine so Docker image is cached through Google's mirror #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sarahkadar
Copy link

@sarahkadar sarahkadar commented Jun 30, 2022

  • Added arm64 support for the entrypoint (we use self-hosted arm64 runners)
  • Switched image to alpine:latest because that gets cached with Google's Docker Hub mirror. This latter is important because the Docker image gets build before I could even log in to Docker Hub, and I get hit with the pull limit. However Google only ever caches the latest tag of public images.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2022

CLA assistant check
All committers have signed the CLA.

Dockerfile Show resolved Hide resolved
Copy link
Contributor

@owenrumney owenrumney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to base image version but otherwise great, thanks!

set weekly schedule for less noise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants