Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pkg/logger to be a standalone package #2599

Closed
geyslan opened this issue Jan 17, 2023 · 6 comments
Closed

change pkg/logger to be a standalone package #2599

geyslan opened this issue Jan 17, 2023 · 6 comments
Assignees

Comments

@geyslan
Copy link
Member

geyslan commented Jan 17, 2023

Being a standalone package, logger can be used by libbpfgo.

Context:

@geyslan geyslan self-assigned this Jan 17, 2023
geyslan added a commit to geyslan/tracee that referenced this issue Jan 17, 2023
@yanivagman
Copy link
Collaborator

@geyslan I believe this is part of the effort for #2417 , right?
If so, no need for a new issue

@geyslan
Copy link
Member Author

geyslan commented Jan 18, 2023

Could #2417 be an EPIC?

@yanivagman
Copy link
Collaborator

You mean that you want to keep this issue and link #2417 back here?
I don't think #2417 is that big to make it an epic, but if you prefer keeping this issue, we shuold remove the kind/feature label

@geyslan
Copy link
Member Author

geyslan commented Jan 18, 2023

Yes, I do prefer to keep this, since after this merge I need to raise other PR to remove the replace in go.mod.

@rafaeldtinoco
Copy link
Contributor

Yes, I do prefer to keep this, since after this merge I need to raise other PR to remove the replace in go.mod.

IMO we should avoid so many issues for so simple things (like replacing go.mod) if you don't mind. We're trying to reduce maintainership burden. Would that be ok ?

@geyslan
Copy link
Member Author

geyslan commented Jan 18, 2023

Ok, no worries. Let's close this.

@geyslan geyslan closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants