Revert "fix: print_mem_dump fails on missing symbol (#3384)" #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1a47a4e. This is done because the commit cause the "symbols_loaded" event to fail and also cause many error messages that weren't seen before.
AlonZivony
force-pushed
the
bugfix/revert-ksymbols-fetching
branch
from
f5d7b28 to
4041209
Compare
|
What brakes the E2E tests is the following change:
But the change Nadav did to the event definition ksymbols dependency isn't good IMO (and can be mitigated by a very simple change). I'm going to merge this reversion and suggest a PR that fixes: #3382. Im going to leave the issue: #3383 opened to fix it in a further moment (as the behavior does not break anything and it's a "good to have" change). |
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This reverts commit 1a47a4e. This is done because the commit cause the "symbols_loaded" event to fail and also cause many error messages that weren't seen before.